Issue 354763005: DevTools: timeline doesn't show records in TimelineView the first view was TimelineFlameChart view.

Issue 354763005: DevTools: timeline doesn't show records in TimelineView the first view was TimelineFlameChart view. (Closed)

Created:
6 years, 5 months ago by loislo

Modified:
6 years, 5 months ago

Reviewers:
alph, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: timeline doesn't show records in TimelineView the first view was TimelineFlameChart view. The root of problem was the fact that addRecord has been called only for currentViews. So we need to refill the view when it become active. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177454

Patch Set 1 #

Patch Set 2 : slightly changed #

Patch Set 3 : minor change #

Patch Set 4 : unnecessary line was removed #

Total comments: 1

Patch Set 5 : comments addressed #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelinePresentationModel.js	View	1 3	1 chunk	+8 lines, -0 lines	0 comments	Download
	M	Source/devtools/front_end/timeline/TimelineView.js	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

alph

lgtm w/nit https://codereview.chromium.org/354763005/diff/50001/Source/devtools/front_end/timeline/TimelineView.js File Source/devtools/front_end/timeline/TimelineView.js (right): https://codereview.chromium.org/354763005/diff/50001/Source/devtools/front_end/timeline/TimelineView.js#newcode310 Source/devtools/front_end/timeline/TimelineView.js:310: WebInspector.View.prototype.wasShown.call(this); nit: Should be HBox

6 years, 5 months ago (2014-07-02 07:33:07 UTC) #3

loislo

On 2014/07/02 07:33:07, alph wrote: > lgtm w/nit > > https://codereview.chromium.org/354763005/diff/50001/Source/devtools/front_end/timeline/TimelineView.js > File Source/devtools/front_end/timeline/TimelineView.js (right): ...

6 years, 5 months ago (2014-07-03 04:48:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/354763005/70001

6 years, 5 months ago (2014-07-03 04:49:52 UTC) #6

Message was sent while issue was closed.

Change committed as 177454

Expand Messages | Collapse Messages