- Implement Isolate.pause and Isolate.resume.

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/thread.h"
 #include "vm/base_isolate.h"
 #include "vm/class_table.h"
 #include "vm/counters.h"
 #include "vm/handles.h"
 #include "vm/megamorphic_cache_table.h"
 #include "vm/random.h"
 #include "vm/store_buffer.h"
 #include "vm/tags.h"
 #include "vm/trace_buffer.h"
 #include "vm/timer.h"
 
 namespace dart {
 
 // Forward declarations.
 class AbstractType;
 class ApiState;
 class Array;
+class Capability;
 class Class;
 class Code;
 class CodeIndexTable;
 class Debugger;
 class DeoptContext;
 class Error;
 class ExceptionHandlers;
 class Field;
 class Function;
 class GrowableObjectArray;
@@ skipping 120 matching lines @@
 
   const char* name() const { return name_; }
 
   int64_t start_time() const { return start_time_; }
 
   Dart_Port main_port() const { return main_port_; }
   void set_main_port(Dart_Port port) {
     ASSERT(main_port_ == 0);  // Only set main port once.
     main_port_ = port;
   }
+  void set_pause_capability(uint64_t value) { pause_capability_ = value; }
+  uint64_t pause_capability() const { return pause_capability_; }
+  void set_terminate_capability(uint64_t value) {
+    terminate_capability_ = value;
+  }
+  uint64_t terminate_capability() const { return terminate_capability_; }
 
   Heap* heap() const { return heap_; }
   void set_heap(Heap* value) { heap_ = value; }
   static intptr_t heap_offset() { return OFFSET_OF(Isolate, heap_); }
 
   ObjectStore* object_store() const { return object_store_; }
   void set_object_store(ObjectStore* value) { object_store_ = value; }
   static intptr_t object_store_offset() {
     return OFFSET_OF(Isolate, object_store_);
   }
@@ skipping 169 matching lines @@
   }
 
   // Returns whether the vm service has requested that the debugger
   // resume execution.
   bool GetAndClearResumeRequest() {
     bool resume_request = resume_request_;
     resume_request_ = false;
     return resume_request;
   }
 
+  // Verify that the sender had the capability to pause this isolate.

[siva, 2014/07/01 21:42:56]

sender has

[Ivan Posva, 2014/07/03 12:51:17]

Done.

+  bool VerifyPauseCapability(const Capability& capability);

[siva, 2014/07/01 21:42:56]

) const;

[Ivan Posva, 2014/07/03 12:51:16]

Done.

+  // Returns true if the capability was added or removed from this isolate's
+  // list of pause events.
+  bool AddPauseCapability(const Capability& capability);

[Ivan Posva, 2014/07/03 12:51:17]

Renamed to resume capabilities and refactored the rest of the code as these are
really capabilities for resume and not pause. I found it confusing to have
VerifyPauseCapability sitting right next to this.

+  bool RemovePauseCapability(const Capability& capability);
+
   Random* random() { return &random_; }
 
   Simulator* simulator() const { return simulator_; }
   void set_simulator(Simulator* value) { simulator_ = value; }
 
   Dart_GcPrologueCallback gc_prologue_callback() const {
     return gc_prologue_callback_;
   }
 
   void set_gc_prologue_callback(Dart_GcPrologueCallback callback) {
@@ skipping 219 matching lines @@
 
   static ThreadLocalKey isolate_key;
 
   StoreBuffer store_buffer_;
   ClassTable class_table_;
   MegamorphicCacheTable megamorphic_cache_table_;
   Dart_MessageNotifyCallback message_notify_callback_;
   char* name_;
   int64_t start_time_;
   Dart_Port main_port_;
+  uint64_t pause_capability_;
+  uint64_t terminate_capability_;
   Heap* heap_;
   ObjectStore* object_store_;
   RawContext* top_context_;
   uword top_exit_frame_info_;
   void* init_callback_data_;
   Dart_EnvironmentCallback environment_callback_;
   Dart_LibraryTagHandler library_tag_handler_;
   ApiState* api_state_;
   StubCode* stub_code_;
   Debugger* debugger_;
@@ skipping 178 matching lines @@
   char* script_url_;
   char* library_url_;
   char* class_name_;
   char* function_name_;
   char* exception_callback_name_;
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_