- Implement Isolate.pause and Isolate.resume.

runtime/lib/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 148 matching lines @@
     Isolate::SetCurrent(parent_isolate);
     return false;
   }
   state->set_isolate(reinterpret_cast<Isolate*>(child_isolate));
 
   Isolate::SetCurrent(parent_isolate);
   return true;
 }
 
 
-static RawObject* Spawn(NativeArguments* arguments, IsolateSpawnState* state) {
+static RawArray* Spawn(Isolate* isolate,

[siva, 2014/07/01 21:42:56]

This isolate parameter is not being used anywhere in the function, if it is for
use in the Handle creation function maybe we should call the parameter
spawning_isolate to make things clear.

Also maybe a local variable:
Isolate* spawned_isolate = state->isolate();

[Ivan Posva, 2014/07/03 12:51:16]

- Removed the unnecessary parameter, it was used in a intermediate
implementation.
- Introduced the local variable spawned_isolate to make it clear what is
happening.

+                       NativeArguments* arguments,
+                       IsolateSpawnState* state) {
   // Create a new isolate.
   char* error = NULL;
   if (!CreateIsolate(state, &error)) {
     delete state;
     const String& msg = String::Handle(String::New(error));
     free(error);
     ThrowIsolateSpawnException(msg);
   }
 
+  const Array& result = Array::Handle(Array::New(3));
   // Try to create a SendPort for the new isolate.
   const SendPort& port = SendPort::Handle(
       SendPort::New(state->isolate()->main_port()));
+  result.SetAt(0, port);
+  Capability& capability = Capability::Handle();
+  capability = Capability::New(state->isolate()->pause_capability());
+  result.SetAt(1, capability);  // pauseCapability
+  capability = Capability::New(state->isolate()->terminate_capability());
+  result.SetAt(2, capability);  // terminateCapability
 
   // Start the new isolate if it is already marked as runnable.
   MutexLocker ml(state->isolate()->mutex());
   state->isolate()->set_spawn_state(state);
   if (state->isolate()->is_runnable()) {
     state->isolate()->Run();
   }
 
-  return port.raw();
+  return result.raw();
 }
 
 
 DEFINE_NATIVE_ENTRY(Isolate_spawnFunction, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, closure, arguments->NativeArgAt(0));
   if (closure.IsClosure()) {
     Function& func = Function::Handle();
     func = Closure::function(closure);
     if (func.IsImplicitClosureFunction() && func.is_static()) {
 #if defined(DEBUG)
       Context& ctx = Context::Handle();
       ctx = Closure::context(closure);
       ASSERT(ctx.num_variables() == 0);
 #endif
-      return Spawn(arguments, new IsolateSpawnState(func));
+      return Spawn(isolate, arguments, new IsolateSpawnState(func));
     }
   }
   const String& msg = String::Handle(String::New(
       "Isolate.spawn expects to be passed a static or top-level function"));
   Exceptions::ThrowArgumentError(msg);
   return Object::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Isolate_spawnUri, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(String, uri, arguments->NativeArgAt(0));
 
   // Canonicalize the uri with respect to the current isolate.
   char* error = NULL;
   char* canonical_uri = NULL;
   const Library& root_lib =
       Library::Handle(arguments->isolate()->object_store()->root_library());
   if (!CanonicalizeUri(arguments->isolate(), root_lib, uri,
                        &canonical_uri, &error)) {
     const String& msg = String::Handle(String::New(error));
     ThrowIsolateSpawnException(msg);
   }
 
-  return Spawn(arguments, new IsolateSpawnState(canonical_uri));
+  return Spawn(isolate, arguments, new IsolateSpawnState(canonical_uri));
+}
+
+
+DEFINE_NATIVE_ENTRY(Isolate_sendOOB, 2) {
+  GET_NON_NULL_NATIVE_ARGUMENT(SendPort, port, arguments->NativeArgAt(0));
+  GET_NON_NULL_NATIVE_ARGUMENT(Array, msg, arguments->NativeArgAt(1));
+
+  // Make sure to route this request to the isolate library OOB mesage handler.
+  msg.SetAt(0, Smi::Handle(Smi::New(Message::kIsolateLibOOBMsg)));
+
+  uint8_t* data = NULL;
+  MessageWriter writer(&data, &allocator);
+  writer.WriteMessage(msg);
+
+  PortMap::PostMessage(new Message(port.Id(),
+                                   data, writer.BytesWritten(),
+                                   Message::kOOBPriority));
+  return Object::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Isolate_mainPort, 0) {
   // The control port is being accessed as a regular port from Dart code. This
   // is most likely due to the _startIsolate code in dart:isolate. Account for
   // this by increasing the number of open control ports.
   isolate->message_handler()->increment_control_ports();
 
   return ReceivePort::New(isolate->main_port());
 }
 
 }  // namespace dart