Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 354763003: Pepper: Add External_OES texture target to PPB_VideoDecoder docs and example. (Closed)

Created:
6 years, 5 months ago by bbudge
Modified:
6 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, Sam Clegg, ihf+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pepper: Add GL_TEXTURE_EXTERNAL_OES texture target to PPB_VideoDecoder docs and example. GL_TEXTURE_2D is used by x86 non-OSX platforms and by software fallback. GL_TEXTURE_RECTANGLE_ARB will be used on OSX hardware. GL_TEXTURE_EXTERNAL_OES is used on ARM ChromeOS. BUG=281689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282674

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -20 lines) Patch
M native_client_sdk/src/examples/api/video_decode/video_decode.cc View 1 14 chunks +71 lines, -13 lines 0 comments Download
M ppapi/api/pp_codecs.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/c/pp_codecs.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ppapi/examples/video_decode/video_decode.cc View 5 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bbudge
+Ben for sdk
6 years, 5 months ago (2014-07-10 00:29:14 UTC) #1
dmichael (off chromium)
ppapi lgtm
6 years, 5 months ago (2014-07-10 16:06:44 UTC) #2
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 5 months ago (2014-07-10 17:25:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/354763003/20001
6 years, 5 months ago (2014-07-10 17:26:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 20:07:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 20:13:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79211)
6 years, 5 months ago (2014-07-10 20:13:56 UTC) #7
binji
lgtm, make sure to ran SDK trybots (the CQ doesn't run them)
6 years, 5 months ago (2014-07-11 17:02:35 UTC) #8
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 5 months ago (2014-07-11 19:51:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/354763003/20001
6 years, 5 months ago (2014-07-11 19:52:00 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 20:01:49 UTC) #11
Message was sent while issue was closed.
Change committed as 282674

Powered by Google App Engine
This is Rietveld 408576698