Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 354763002: Remove WebElement::hasTagName. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
keishi, Ilya Sherman
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Remove WebElement::hasTagName. There are no callsites in Chromium. This function is unsafe because it ignores namespace URI. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176895 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M Source/web/WebElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebElement.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tkent
Would you review this please?
6 years, 6 months ago (2014-06-25 00:17:00 UTC) #1
Ilya Sherman
LGTM. Thanks! :)
6 years, 6 months ago (2014-06-25 01:38:24 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-25 01:47:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/354763002/1
6 years, 6 months ago (2014-06-25 01:48:49 UTC) #4
commit-bot: I haz the power
Change committed as 176895
6 years, 6 months ago (2014-06-25 01:51:48 UTC) #5
tkent
A revert of this CL has been created in https://codereview.chromium.org/350433004/ by tkent@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-25 04:07:31 UTC) #6
tkent
On 2014/06/25 04:07:31, tkent wrote: > A revert of this CL has been created in ...
6 years, 6 months ago (2014-06-25 04:11:15 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-27 02:59:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/354763002/1
6 years, 6 months ago (2014-06-27 03:00:35 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 03:03:06 UTC) #10
Message was sent while issue was closed.
Change committed as 177049

Powered by Google App Engine
This is Rietveld 408576698