Notifications API support for images with multiple scale factors.

Notifications API support for images with multiple scale factors.

To date, the notifications API supported only one representation per
image.  This means the experience could be degraded if the user changed
scale factors dynamically or had multiple monitors with differing scale
factors.  This updates the API to allow specification of multiple
representations with differing scale factors.

BUG=239676

[benwells, 2014-06-27 03:15:27]

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/notifications.idl (right):

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/notifications.idl:59: ImageRepresentation[]? icons;
I think having these names be plural is confusing. There is only one icon being
provided but it is being produced with multiple representations.

Can we call it something like iconReps? Same goes for the notification options.

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/notifications.idl:67: // Sender's avatar, app icon,
or a thumbnail for image notifications.
Are we intending notifications to have app icons here? I thought this would be
more notification specific, with the new app mask being how to communicate the
responsible app.

[dewittj, 2014-07-01 15:06:11]

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/notifications.idl (right):

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/notifications.idl:59: ImageRepresentation[]? icons;
On 2014/06/27 03:15:27, benwells wrote:
> I think having these names be plural is confusing. There is only one icon
being
> provided but it is being produced with multiple representations.
> 
> Can we call it something like iconReps? Same goes for the notification
options.

Done.

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/notifications.idl:67: // Sender's avatar, app icon,
or a thumbnail for image notifications.
On 2014/06/27 03:15:27, benwells wrote:
> Are we intending notifications to have app icons here? I thought this would be
> more notification specific, with the new app mask being how to communicate the
> responsible app.

We haven't been too prescriptive about what is acceptable in each area of the
UI, and I think that's a good thing.  When I've written apps for the
notification center, I frequently use people's images when available, but
generic icons if there isn't a more specific picture for this particular data. 
So probably we should leave this more generic but also publish a
google-style-guide similar to the Android one that has guidelines for app
developers.

See also http://developer.android.com/design/patterns/notifications.html

[benwells, 2014-07-02 03:11:11]

(not doing a full review yet until the proposal thread has settled down a bit).

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/notifications.idl (right):

https://codereview.chromium.org/354733002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/notifications.idl:67: // Sender's avatar, app icon,
or a thumbnail for image notifications.
On 2014/07/01 15:06:11, dewittj wrote:
> On 2014/06/27 03:15:27, benwells wrote:
> > Are we intending notifications to have app icons here? I thought this would
be
> > more notification specific, with the new app mask being how to communicate
the
> > responsible app.
> 
> We haven't been too prescriptive about what is acceptable in each area of the
> UI, and I think that's a good thing.  When I've written apps for the
> notification center, I frequently use people's images when available, but
> generic icons if there isn't a more specific picture for this particular data.

> So probably we should leave this more generic but also publish a
> google-style-guide similar to the Android one that has guidelines for app
> developers.
> 
> See also http://developer.android.com/design/patterns/notifications.html

I was thinking about the comment here not the name. I agree we don't want to be
prescriptive, however it might make sense to give guidance in the documentation
about what we think best practices are.

E.g. we could say here that "ideally this is an image for this specific
notification, e.g. avatar or a thumbnail. If there is nothing suitable a generic
app image is acceptable." blah blah blah.

[dewittj, 2014-08-18 20:36:05]

maybe a codereview ping will work better than an apps-dev one?

[dewittj, 2016-01-15 00:06:02]

Description was changed from

==========
Notifications API support for images with multiple scale factors.

To date, the notifications API supported only one representation per
image.  This means the experience could be degraded if the user changed
scale factors dynamically or had multiple monitors with differing scale
factors.  This updates the API to allow specification of multiple
representations with differing scale factors.

BUG=239676
==========

to

==========
Notifications API support for images with multiple scale factors.

To date, the notifications API supported only one representation per
image.  This means the experience could be degraded if the user changed
scale factors dynamically or had multiple monitors with differing scale
factors.  This updates the API to allow specification of multiple
representations with differing scale factors.

BUG=239676
==========