Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 3547005: Documentation update: device-lowlevel-api and service-api (Closed)

Created:
10 years, 2 months ago by Daniel Kurtz
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Nathan Williams, Eric Shienbrood, Jason Glasgow, rochberg, Paul Stewart
Visibility:
Public.

Description

Documentation update: device-lowlevel-api and service-api Change-Id: I398e2937f2626e4bf0550160cc792afb74ae1c6a BUG=none TEST=read documentation Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8a0fe64

Patch Set 1 #

Total comments: 24

Patch Set 2 : Updated per review feedback. #

Total comments: 6

Patch Set 3 : Removed ambiguous description of Device.Scanning property #

Patch Set 4 : Fixed some typos #

Patch Set 5 : Rebase onto 0.9.78 #

Patch Set 6 : Minor typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -26 lines) Patch
M doc/device-lowlevel-api.txt View 1 2 3 4 5 6 chunks +94 lines, -10 lines 0 comments Download
M doc/service-api.txt View 1 2 3 4 9 chunks +56 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Daniel Kurtz
10 years, 2 months ago (2010-09-30 04:46:40 UTC) #1
Sam Leffler
http://codereview.chromium.org/3547005/diff/1/2 File doc/device-lowlevel-api.txt (right): http://codereview.chromium.org/3547005/diff/1/2#newcode94 doc/device-lowlevel-api.txt:94: indication. Actually bgscan's are meant to be visible through ...
10 years, 2 months ago (2010-10-01 17:16:22 UTC) #2
Eric Shienbrood
http://codereview.chromium.org/3547005/diff/1/2 File doc/device-lowlevel-api.txt (right): http://codereview.chromium.org/3547005/diff/1/2#newcode157 doc/device-lowlevel-api.txt:157: If the device type is "cellular", then this property ...
10 years, 2 months ago (2010-10-01 18:07:35 UTC) #3
Daniel Kurtz
http://codereview.chromium.org/3547005/diff/1/2 File doc/device-lowlevel-api.txt (right): http://codereview.chromium.org/3547005/diff/1/2#newcode94 doc/device-lowlevel-api.txt:94: indication. On 2010/10/01 17:16:23, Sam Leffler wrote: > Actually ...
10 years, 2 months ago (2010-10-03 00:48:18 UTC) #4
Eric Shienbrood
LGTM
10 years, 2 months ago (2010-10-03 01:41:06 UTC) #5
Sam Leffler
http://codereview.chromium.org/3547005/diff/7001/8001 File doc/device-lowlevel-api.txt (right): http://codereview.chromium.org/3547005/diff/7001/8001#newcode96 doc/device-lowlevel-api.txt:96: notifying the driver. Where did this last sentence come ...
10 years, 2 months ago (2010-10-03 19:15:02 UTC) #6
Daniel Kurtz
http://codereview.chromium.org/3547005/diff/7001/8001 File doc/device-lowlevel-api.txt (right): http://codereview.chromium.org/3547005/diff/7001/8001#newcode96 doc/device-lowlevel-api.txt:96: notifying the driver. On 2010/10/03 19:15:02, Sam Leffler wrote: ...
10 years, 2 months ago (2010-10-03 20:17:09 UTC) #7
Sam Leffler
http://codereview.chromium.org/3547005/diff/7001/8001 File doc/device-lowlevel-api.txt (right): http://codereview.chromium.org/3547005/diff/7001/8001#newcode96 doc/device-lowlevel-api.txt:96: notifying the driver. I don't want to support this ...
10 years, 2 months ago (2010-10-04 17:51:57 UTC) #8
Daniel Kurtz
http://codereview.chromium.org/3547005/diff/7001/8001 File doc/device-lowlevel-api.txt (right): http://codereview.chromium.org/3547005/diff/7001/8001#newcode96 doc/device-lowlevel-api.txt:96: notifying the driver. On 2010/10/04 17:51:58, Sam Leffler wrote: ...
10 years, 2 months ago (2010-10-04 21:07:56 UTC) #9
Sam Leffler
10 years, 2 months ago (2010-10-08 16:09:05 UTC) #10
LGTM (sorry for the delay)

Powered by Google App Engine
This is Rietveld 408576698