Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 354693003: delete disabled bench (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
junov1, mtklein, tomhudson
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -107 lines) Patch
D bench/DeferredCanvasBench.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 6 months ago (2014-06-24 20:55:59 UTC) #1
tomhudson
LGTM. But + Justin: Justin, I think you signed off on the previous change without ...
6 years, 6 months ago (2014-06-24 21:00:18 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-24 21:00:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/354693003/1
6 years, 6 months ago (2014-06-24 21:01:24 UTC) #4
commit-bot: I haz the power
Change committed as 32492e82040cadc92a9b15ae266301bdc94523b3
6 years, 6 months ago (2014-06-24 21:16:54 UTC) #5
Justin Novosad
On 2014/06/24 21:00:18, tomhudson wrote: > LGTM. > > But + Justin: Justin, I think ...
6 years, 6 months ago (2014-06-25 15:03:48 UTC) #6
tomhudson
6 years, 6 months ago (2014-06-25 15:10:31 UTC) #7
Message was sent while issue was closed.
On 2014/06/25 15:03:48, junov wrote:
> Can you remind me why this test was disabled in the first place?  And what is
> unclean about it?

That's a question for reed@, but I think it was because the factory or
constructor it used was deprecated?

Powered by Google App Engine
This is Rietveld 408576698