Issue 354673005: Revert "[Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354673005: Revert "[Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault" (Closed)

Created:
6 years, 6 months ago by Yufeng Shen (Slow to review)

Modified:
6 years, 6 months ago

Reviewers:
jeremy

CC:
chromium-reviews, glider+watch_chromium.org, erikwright+watch_chromium.org, sadrul, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "[Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault" This reverts commit e82339d44d0dde725295785b9fea8c448d382621. See if this fixes the perf regression. BUG=388360 TBR=jeremy@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279474

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -99 lines)			Patch
M	base/message_loop/message_loop.cc	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	base/message_loop/message_pump_default.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	jingle/glue/chrome_async_socket_unittest.cc	View	26 chunks	+39 lines, -48 lines	0 comments	Download
M	jingle/notifier/base/xmpp_connection_unittest.cc	View	6 chunks	+9 lines, -14 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View	2 chunks	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yufeng Shen (Slow to review)

The CQ bit was checked by miletus@chromium.org

6 years, 6 months ago (2014-06-24 20:01:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/354673005/1

6 years, 6 months ago (2014-06-24 20:02:40 UTC) #2

jeremy

6 years, 6 months ago (2014-06-25 17:38:28 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/349933004/ by jeremy@chromium.org.

The reason for reverting is: Original revert was due to a perf regression, which
turned out to be nothing - see crbug.com/388360 for details..

Expand Messages | Collapse Messages