fpdfsdk/include/fsdk_mgr.h - Issue 354673002: Fix and integer overflow issue in SDK's QuickSort

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/fsdk_mgr.h

Issue 354673002: Fix and integer overflow issue in SDK's QuickSort (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/fsdk_mgr.h

diff --git a/fpdfsdk/include/fsdk_mgr.h b/fpdfsdk/include/fsdk_mgr.h

index bb25b35e976d4f6f84c63bc93482df7f53f3284b..e6a9219c88301920c698732aca401c25b10d7fed 100644

--- a/fpdfsdk/include/fsdk_mgr.h

+++ b/fpdfsdk/include/fsdk_mgr.h

@@ -564,7 +564,7 @@ private:

return;

}

- FX_UINT m = (nStartPos + nStopPos) / 2;

+ FX_UINT m = nStartPos + (nStopPos - nStartPos) / 2;

FX_UINT i = nStartPos;

TYPE Value = this->GetAt(m);

« no previous file with comments | « no previous file | no next file » | no next file with comments »