Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 354643003: ServiceWorker: Support navigator.serviceWorker.active (Closed)

Created:
6 years, 5 months ago by nhiroki
Modified:
6 years, 5 months ago
Reviewers:
falken, michaeln, jschuh
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org, dominicc (has gone to gerrit)
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Support navigator.serviceWorker.active This change plumbs '.active' and you will be able to access an active worker via 'navigator.serviceWorker.active'. BUG=379012 TEST=content_unittest --gtest_filter=ServiceWorker* TEST=run_webkit_tests.py http/tests/serviceworker/waiting.html TEST=run_webkit_tests.py http/tests/serviceworker/active.html (http://crrev.com/373013002) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282006

Patch Set 1 : #

Total comments: 2

Patch Set 2 : comment fix #

Messages

Total messages: 9 (0 generated)
nhiroki
Ptal, thanks!
6 years, 5 months ago (2014-07-08 08:33:20 UTC) #1
nhiroki
+jschuh@ Hi Justin, could you review service_worker_messages.h? Thanks.
6 years, 5 months ago (2014-07-08 14:38:22 UTC) #2
jschuh
ipc security lgtm (notes: browser -> renderer URLs and routing info).
6 years, 5 months ago (2014-07-08 17:15:22 UTC) #3
michaeln
lgtm https://codereview.chromium.org/354643003/diff/200001/content/child/service_worker/service_worker_provider_context.cc File content/child/service_worker/service_worker_provider_context.cc (right): https://codereview.chromium.org/354643003/diff/200001/content/child/service_worker/service_worker_provider_context.cc#newcode66 content/child/service_worker/service_worker_provider_context.cc:66: which = active_.get(); style nit: these one line ...
6 years, 5 months ago (2014-07-09 02:07:06 UTC) #4
nhiroki
https://codereview.chromium.org/354643003/diff/200001/content/child/service_worker/service_worker_provider_context.cc File content/child/service_worker/service_worker_provider_context.cc (right): https://codereview.chromium.org/354643003/diff/200001/content/child/service_worker/service_worker_provider_context.cc#newcode66 content/child/service_worker/service_worker_provider_context.cc:66: which = active_.get(); On 2014/07/09 02:07:05, michaeln wrote: > ...
6 years, 5 months ago (2014-07-09 06:14:27 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 5 months ago (2014-07-09 06:15:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/354643003/240001
6 years, 5 months ago (2014-07-09 06:16:37 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 10:07:08 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 11:57:28 UTC) #9
Message was sent while issue was closed.
Change committed as 282006

Powered by Google App Engine
This is Rietveld 408576698