Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 354613003: Properly repaint RenderLayer's descendants when it moves (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use a flag instead of a seperate tree walk. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 TRACE_EVENT0("blink_rendering", "RenderLayer::updateLayerPositionsAfterLayou t"); 252 TRACE_EVENT0("blink_rendering", "RenderLayer::updateLayerPositionsAfterLayou t");
253 253
254 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues 254 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues
255 // https://code.google.com/p/chromium/issues/detail?id=343756 255 // https://code.google.com/p/chromium/issues/detail?id=343756
256 DisableCompositingQueryAsserts disabler; 256 DisableCompositingQueryAsserts disabler;
257 updateLayerPositionRecursive(flags); 257 updateLayerPositionRecursive(flags);
258 } 258 }
259 259
260 void RenderLayer::updateLayerPositionRecursive(UpdateLayerPositionsFlags flags) 260 void RenderLayer::updateLayerPositionRecursive(UpdateLayerPositionsFlags flags)
261 { 261 {
262 updateLayerPosition(); 262 if (flags & ForceMayNeedPaintInvalidation)
263 m_renderer->setMayNeedPaintInvalidation(true);
264
265 if (updateLayerPosition())
266 flags |= ForceMayNeedPaintInvalidation;
263 267
264 // Clear our cached clip rect information. 268 // Clear our cached clip rect information.
265 m_clipper.clearClipRects(); 269 m_clipper.clearClipRects();
266 270
267 if (hasOverflowControls()) { 271 if (hasOverflowControls()) {
268 // FIXME: We should figure out the right time to position the overflow c ontrols. 272 // FIXME: We should figure out the right time to position the overflow c ontrols.
269 // This call appears to be necessary to pass some layout test that use E ventSender, 273 // This call appears to be necessary to pass some layout test that use E ventSender,
270 // presumably because the normal time to position the controls is during paint. We 274 // presumably because the normal time to position the controls is during paint. We
271 // probably shouldn't position the overflow controls during paint either ... 275 // probably shouldn't position the overflow controls during paint either ...
272 scrollableArea()->positionOverflowControls(IntSize()); 276 scrollableArea()->positionOverflowControls(IntSize());
(...skipping 3508 matching lines...) Expand 10 before | Expand all | Expand 10 after
3781 } 3785 }
3782 } 3786 }
3783 3787
3784 void showLayerTree(const WebCore::RenderObject* renderer) 3788 void showLayerTree(const WebCore::RenderObject* renderer)
3785 { 3789 {
3786 if (!renderer) 3790 if (!renderer)
3787 return; 3791 return;
3788 showLayerTree(renderer->enclosingLayer()); 3792 showLayerTree(renderer->enclosingLayer());
3789 } 3793 }
3790 #endif 3794 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698