[DBus] Explicitly instantiate dbus::Property variants

dbus/property.h

Index: dbus/property.h
diff --git a/dbus/property.h b/dbus/property.h
index f6baffc8a7343cb6e07444fffc28e69ae79e9726..bfbddbe51aced15a6465cd7fa2a2be0374820609 100644
--- a/dbus/property.h
+++ b/dbus/property.h
@@ -350,7 +350,7 @@ class CHROME_DBUS_EXPORT PropertySet {
 // default value. Specializations for basic D-Bus types, strings, object
 // paths and arrays are provided for you.
 template <class T>
-class CHROME_DBUS_EXPORT Property : public PropertyBase {
+class Property : public PropertyBase {

[keybuk, 2014/06/26 05:01:46]

what about the other classes, e.g. PropertyBase and PropertySet?

[tzik, 2014/06/26 05:25:56]

Since PropertySet is not a template class, its member's symbols are created and
exported in property.cc, which is in libdbus.
For PropertyBase, Init() is called only from property.cc, which doesn't cause
link failure.
Other non-inline members are pure virtual, I'm not familiar to this case, but it
looks like calling virtual functions doesn't need symbol export.

  public:
   Property() {}
 
@@ -409,67 +409,81 @@ class CHROME_DBUS_EXPORT Property : public PropertyBase {
 template <> Property<uint8>::Property();
 template <> bool Property<uint8>::PopValueFromReader(MessageReader* reader);
 template <> void Property<uint8>::AppendSetValueToWriter(MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<uint8>;
 
 template <> Property<bool>::Property();
 template <> bool Property<bool>::PopValueFromReader(MessageReader* reader);
 template <> void Property<bool>::AppendSetValueToWriter(MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<bool>;
 
 template <> Property<int16>::Property();
 template <> bool Property<int16>::PopValueFromReader(MessageReader* reader);
 template <> void Property<int16>::AppendSetValueToWriter(MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<int16>;
 
 template <> Property<uint16>::Property();
 template <> bool Property<uint16>::PopValueFromReader(MessageReader* reader);
 template <> void Property<uint16>::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<uint16>;
 
 template <> Property<int32>::Property();
 template <> bool Property<int32>::PopValueFromReader(MessageReader* reader);
 template <> void Property<int32>::AppendSetValueToWriter(MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<int32>;
 
 template <> Property<uint32>::Property();
 template <> bool Property<uint32>::PopValueFromReader(MessageReader* reader);
 template <> void Property<uint32>::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<uint32>;
 
 template <> Property<int64>::Property();
 template <> bool Property<int64>::PopValueFromReader(MessageReader* reader);
 template <> void Property<int64>::AppendSetValueToWriter(MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<int64>;
 
 template <> Property<uint64>::Property();
 template <> bool Property<uint64>::PopValueFromReader(MessageReader* reader);
 template <> void Property<uint64>::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<uint64>;
 
 template <> Property<double>::Property();
 template <> bool Property<double>::PopValueFromReader(MessageReader* reader);
 template <> void Property<double>::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<double>;
 
 template <> bool Property<std::string>::PopValueFromReader(
   MessageReader* reader);
 template <> void Property<std::string>::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<std::string>;
 
 template <> bool Property<ObjectPath>::PopValueFromReader(
   MessageReader* reader);
 template <> void Property<ObjectPath>::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<ObjectPath>;
 
 template <> bool Property<std::vector<std::string> >::PopValueFromReader(
   MessageReader* reader);
 template <> void Property<std::vector<std::string> >::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<std::vector<std::string> >;
 
 template <> bool Property<std::vector<ObjectPath> >::PopValueFromReader(
   MessageReader* reader);
 template <> void Property<std::vector<ObjectPath> >::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<std::vector<ObjectPath> >;
 
 template <> bool Property<std::vector<uint8> >::PopValueFromReader(
   MessageReader* reader);
 template <> void Property<std::vector<uint8> >::AppendSetValueToWriter(
   MessageWriter* writer);
+template class CHROME_DBUS_EXPORT Property<std::vector<uint8> >;
 
 }  // namespace dbus