Issue 354543002: Gallery.app: Fix removeEventListener call in Gallery.app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354543002: Gallery.app: Fix removeEventListener call in Gallery.app. (Closed)

Created:
6 years, 6 months ago by hirono

Modified:
6 years, 6 months ago

Reviewers:
fukino

CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Gallery.app: Fix removeEventListener call in Gallery.app. Recently Blink introuduce type checks for arguments of removeEventListner. One call in Gallery.app vaiolates the check and it brokes the gallery browser tests. BUG=388071 TEST=run the gallery browser tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279343

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/file_manager/file_manager_browsertest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	ui/file_manager/gallery/js/image_editor/image_transform.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

fukino

On 2014/06/24 03:24:35, hirono wrote: > PTAL the CL? Thank you! LGTM!

6 years, 6 months ago (2014-06-24 04:11:35 UTC) #2

hirono

On 2014/06/24 04:11:35, fukino wrote: > On 2014/06/24 03:24:35, hirono wrote: > > PTAL the ...

6 years, 6 months ago (2014-06-24 04:15:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/354543002/1

6 years, 6 months ago (2014-06-24 04:16:58 UTC) #5

Message was sent while issue was closed.

Change committed as 279343

Expand Messages | Collapse Messages