src/handles-inl.h - Issue 3545004: [Isolates] Avoid isolate lookup in HandleScope destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles-inl.h

Issue 3545004: [Isolates] Avoid isolate lookup in HandleScope destructor. (Closed)

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/handles-inl.h

diff --git a/src/handles-inl.h b/src/handles-inl.h

index 0088d3a379bef788237c1c6fd74b188e9c3dc97f..6e7c3d972434f16fb7ce410824e22112f1f8649e 100644

--- a/src/handles-inl.h

+++ b/src/handles-inl.h

@@ -127,7 +127,8 @@ void HandleScope::Enter(

void HandleScope::Leave(

const v8::ImplementationUtilities::HandleScopeData* previous) {

- Isolate* isolate = Isolate::Current();

+ Isolate* isolate = previous->isolate;

+ ASSERT(isolate == Isolate::Current());

v8::ImplementationUtilities::HandleScopeData* current =

isolate->handle_scope_data();

if (current->extensions > 0) {

« include/v8.h ('K') | « src/api.cc ('k') | src/isolate.cc » ('j') | no next file with comments »