Issue 3545002: CHROMIUM: config: Enable SMSC95xx USB Ethernet on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3545002: CHROMIUM: config: Enable SMSC95xx USB Ethernet on ARM (Closed)

Created:
10 years, 2 months ago by Stephen Warren

Modified:
9 years, 7 months ago

Reviewers:
Olof Johansson

CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Mandeep Singh Baines, vb

Base URL:
http://git.chromium.org/git/kernel-next.git

Visibility:
Public.

Description

CHROMIUM: config: Enable SMSC95xx USB Ethernet on ARM Change-Id: I8eb7d4a335dfe6f25032066b576e41d3302cf470 Signed-off-by: Stephen Warren <swarren@nvidia.com>; BUG= TEST=Built and ran ChromeOS image on Harmony, and used the Ethernet port

Patch Set 1 #

Patch Set 2 : Modified per review comments. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -3 lines)			Patch
M	chromeos/config/armel/config.common.armel	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/config/config.common.chromeos	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/config/i386/config.common.i386	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/config/x86_64/config.common.x86_64	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Olof Johansson

Hi, please use the following format on the first line of the description: CHROMIUM: config: ...

10 years, 2 months ago (2010-09-28 23:07:31 UTC) #2

stephen.r.warren_gmail.com

On 2010/09/28 23:07:31, Olof Johansson wrote: > Also, please enable the module on all ARM ...

10 years, 2 months ago (2010-09-28 23:12:49 UTC) #3

Olof Johansson

On 2010/09/28 23:12:49, Stephen Warren wrote: > On 2010/09/28 23:07:31, Olof Johansson wrote: > > ...

10 years, 2 months ago (2010-09-28 23:25:34 UTC) #4

LGTM, applied. Thanks!

Expand Messages | Collapse Messages