SPDY cleanup: use ParseFrameType and SerializeFrameType

SPDY cleanup: use ParseFrameType and SerializeFrameType

Instead of SpdyFrameType enum values. Also remove NOOP frames from the
set of recognized frames. No functional change since NOOP frames
are deprecated and not seen in the wild.

This lands server change 68256336 by mlavan.

BUG=

[Ryan Hamilton, 2014-06-25 22:31:33]

lgtm

https://codereview.chromium.org/354483005/diff/20001/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://codereview.chromium.org/354483005/diff/20001/net/spdy/spdy_framer.cc#...
net/spdy/spdy_framer.cc:721: control_frame_type_field != 0;
This is a bit complicated. Consider adding
SpdyConstants::IsControlFrame(frame_type)

[Johnny, 2014-06-26 15:57:24]

https://codereview.chromium.org/354483005/diff/20001/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://codereview.chromium.org/354483005/diff/20001/net/spdy/spdy_framer.cc#...
net/spdy/spdy_framer.cc:721: control_frame_type_field != 0;
On 2014/06/25 22:31:33, Ryan Hamilton wrote:
> This is a bit complicated. Consider adding
> SpdyConstants::IsControlFrame(frame_type)

Hmm. Think this needs a deeper re-factor. It's probably better done as:

is_control_frame = (DATA == SpdyConstants::ParseFrameType(protocol_version(),
control_frame_type_field));

or better:

control_frame_type_ = SpdyConstants::ParseFrameType(protocol_version(),
control_frame_type_field);
is_control_frame = (DATA == control_frame_type_);

But we haven't yet validated that the frame type is valid (thus the gymnastics
here, I think). I'll pass this along.