chrome/browser/guest_view/guest_view_manager.h - Issue 354483004: Implement <appview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_manager.h

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Fixed formatting Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guest_view/guest_view_manager.h

diff --git a/chrome/browser/guest_view/guest_view_manager.h b/chrome/browser/guest_view/guest_view_manager.h

index 4e13efa4c662e2b4088998ee389d88833c8ae1dc..342dcde60b6b8f96b1fba9de20a16036645a312d 100644

--- a/chrome/browser/guest_view/guest_view_manager.h

+++ b/chrome/browser/guest_view/guest_view_manager.h

@@ -14,6 +14,7 @@

#include "content/public/browser/site_instance.h"

#include "content/public/browser/web_contents.h"

+class AppViewGuest;

class GuestViewBase;

class GuestViewManagerFactory;

class GuestWebContentsObserver;

@@ -78,6 +79,7 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

const GuestCallback& callback) OVERRIDE;

protected:

+ friend class AppViewGuest;

friend class GuestViewBase;

friend class GuestWebContentsObserver;

friend class guestview::TestGuestViewManager;

@@ -89,9 +91,7 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

void RemoveGuest(int guest_instance_id);

- content::WebContents* GetGuestByInstanceID(

- int guest_instance_id,

- int embedder_render_process_id);

+ content::WebContents* GetGuestByInstanceID(int guest_instance_id);

bool CanEmbedderAccessInstanceIDMaybeKill(

int embedder_render_process_id,