Implement <appview>

extensions/browser/extensions_browser_client.h

Index: extensions/browser/extensions_browser_client.h
diff --git a/extensions/browser/extensions_browser_client.h b/extensions/browser/extensions_browser_client.h
index 293b2af7039e152ae8fdc8eb6070cc9dac4035c1..5f98de4ca5a03c94e1823604346689b8726edb09 100644
--- a/extensions/browser/extensions_browser_client.h
+++ b/extensions/browser/extensions_browser_client.h
@@ -10,6 +10,7 @@
 
 #include "base/memory/scoped_ptr.h"
 #include "extensions/browser/extension_prefs_observer.h"
+#include "url/gurl.h"
 
 class ExtensionFunctionRegistry;
 class PrefService;
@@ -179,6 +180,15 @@ class ExtensionsBrowserClient {
   virtual ComponentExtensionResourceManager*
   GetComponentExtensionResourceManager() = 0;
 
+  // Completes the creation of a WebContents associated with the provided
+  // |guest_extension_id|. Returns whether the operation was completed
+  // successfully.
+  virtual bool CompletePendingEmbedRequest(

[not at google - send to devlin, 2014/07/10 19:44:16]

kinda weird that there is a "complete" in this interface, but nothing about how
these are initiated. why does it need to be in this interface?

+yoz

[James Cook, 2014/07/10 19:58:06]

I think the primary problem here is that:
1. <appview> is a feature mostly implemented in src/chrome
2. However, it associates its onEmbedded event in app_runtime, which lives in
src/extensions
3. We don't currently have a very good way to express API features that require
code in both places.

Can more of the guest_view / app_view code move into src/extensions?

If not, I think this method should be split into AppViewInternalAttachFrame and
AppViewInternalDenyRequest and moved in ExtensionsApiClient.

rockot might also have an opinion, as he had to deal with this for some
AppWindow refactoring recently.

+      const GURL& url,
+      int guest_instance_id,
+      content::BrowserContext* browser_context,
+      const std::string& guest_extension_id) = 0;
+
   // Returns the single instance of |this|.
   static ExtensionsBrowserClient* Get();