Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: extensions/common/api/app_runtime.idl

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton
Patch Set: Addressed Istiaque's comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/app_runtime.idl
diff --git a/extensions/common/api/app_runtime.idl b/extensions/common/api/app_runtime.idl
index b094c98dade73479514b0204537deb187f90b21f..cc6f87e3f08b2c165fba0b2d5bb281e142baac67 100644
--- a/extensions/common/api/app_runtime.idl
+++ b/extensions/common/api/app_runtime.idl
@@ -42,7 +42,20 @@ namespace app.runtime {
boolean? isKioskSession;
};
+ [inline_doc] dictionary AppEmbeddingRequest {
not at google - send to devlin 2014/07/08 20:54:14 inline_doc is automatic for types that are only us
Fady Samuel 2014/07/08 21:53:10 Done.
+ long? id;
+
+ DOMString embedderExtensionId;
+
+ [nocompile] static void allow(DOMString url, object api, DOMString schema);
+
+ [nocompile] static void deny();
not at google - send to devlin 2014/07/08 20:54:14 these all need comments
Fady Samuel 2014/07/08 21:53:10 Done.
+ };
+
interface Events {
+ // Fired when an embedding app requests to embed this app.
+ static void onAppEmbeddingRequest(AppEmbeddingRequest request);
not at google - send to devlin 2014/07/08 20:54:14 hum. this change needs to go through actual API re
Fady Samuel 2014/07/08 21:53:10 I'll write up an API proposal in parallel. appview
not at google - send to devlin 2014/07/08 22:10:46 That's not quite true, this event can still be lis
Fady Samuel 2014/07/09 15:15:48 Done.
+
// Fired when an app is launched from the launcher.
static void onLaunched(optional LaunchData launchData);

Powered by Google App Engine
This is Rietveld 408576698