chrome/browser/guest_view/guest_view_base.h - Issue 354483004: Implement <appview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_base.h

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Addressed comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guest_view/guest_view_base.h

diff --git a/chrome/browser/guest_view/guest_view_base.h b/chrome/browser/guest_view/guest_view_base.h

index a8b8aa48617d7f787e2005c681e98cbf439bc683..4b6ed1bf9cb10649069ffa7edd7f4a8e4ca6f280 100644

--- a/chrome/browser/guest_view/guest_view_base.h

+++ b/chrome/browser/guest_view/guest_view_base.h

@@ -218,10 +218,10 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

void SendQueuedEvents();

- void CompleteCreateWebContents(const std::string& embedder_extension_id,

- int embedder_render_process_id,

- const WebContentsCreatedCallback& callback,

- content::WebContents* guest_web_contents);

+ void CompleteInit(const std::string& embedder_extension_id,

+ int embedder_render_process_id,

+ const WebContentsCreatedCallback& callback,

+ content::WebContents* guest_web_contents);

// WebContentsObserver implementation.

virtual void DidStopLoading(