chrome/common/extensions/api/app_view_internal.json - Issue 354483004: Implement <appview>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/app_view_internal.json

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Added tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/guest_view/guest_view_manager.h ('K') | « chrome/common/extensions/api/api.gyp ('k') | chrome/common/extensions/api/guest_view_internal.json » ('j') | chrome/renderer/resources/extensions/app_view.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 {	6 {

7 "namespace": "guestViewInternal",	7 "namespace": "appViewInternal",

8 "compiler_options": {	8 "compiler_options": {

9 "implemented_in": "chrome/browser/extensions/api/guest_view/guest_view_int ernal_api.h"	9 "implemented_in": "chrome/browser/extensions/api/guest_view/app_view_inter nal_api.h"

10 },	10 },

11 "description": "none",	11 "description": "none",

12 "functions": [	12 "functions": [

13 {	13 {

14 "name": "createGuest",	14 "name": "attachFrame",

15 "type": "function",	15 "type": "function",
	lazyboy 2014/07/07 21:34:44 Please add a description of what this function doe Please add a description of what this function does. Fady Samuel 2014/07/08 15:47:09 Done. Show quoted text On 2014/07/07 21:34:44, lazyboy wrote: > Please add a description of what this function does. Done.
16 "parameters": [	16 "parameters": [

17 {	17 {

18 "type": "string",	18 "type": "string",

19 "name": "viewType",	19 "name": "url",

20 "nodoc": true	20 "nodoc": true

21 },	21 },

22 {	22 {

23 "type": "object",	23 "type": "integer",

24 "name": "createParams",	24 "name": "guestInstanceId",

25 "properties": {	25 "nodoc": true

26 "storagePartitionId": {

27 "type": "string",

28 "optional": true

29 }

30 }

31 },	26 },

32 {	27 {

33 "type": "function",	28 "type": "function",

34 "name": "callback",	29 "name": "callback",

	30 "optional": true,

35 "parameters": [	31 "parameters": [

36 {	32 {

37 "type": "integer",	33 "type": "integer",

38 "name": "instanceId"	34 "name": "instanceId"

39 }	35 }

40 ]	36 ]

41 }	37 }

42 ]	38 ]

	39 },

	40 {

	41 "name": "denyRequest",

	42 "type": "function",
	lazyboy 2014/07/07 21:34:44 Same as above, add description of this function. Same as above, add description of this function. Fady Samuel 2014/07/08 15:47:09 Done. Show quoted text On 2014/07/07 21:34:44, lazyboy wrote: > Same as above, add description of this function. Done.
	43 "parameters": [

	44 {

	45 "type": "integer",

	46 "name": "guestInstanceId",

	47 "nodoc": true

	48 }

	49 ]

43 }	50 }

44 ]	51 ]

45 }	52 }

46 ]	53 ]

	54

OLD	NEW