chrome/common/extensions/api/app_view_internal.json - Issue 354483004: Implement <appview>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/app_view_internal.json

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Addressed Istiaque's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 {

	7 "namespace": "appViewInternal",

	8 "compiler_options": {

	9 "implemented_in": "chrome/browser/extensions/api/app_view/app_view_interna l_api.h"

	10 },

	11 "description": "none",

	12 "functions": [

	13 {

	14 "name": "attachFrame",

	15 "type": "function",

	16 "description": "Attaches the specified url to the AppView with the provi ded instance ID.",

	17 "parameters": [

	18 {

	19 "type": "string",

	20 "name": "url",

	21 "nodoc": true
	not at google - send to devlin 2014/07/08 20:54:14 you don't need "nodoc" anywhere, since it's implic you don't need "nodoc" anywhere, since it's implicit by it being an internal API (or rather, because you're not adding a HTML file for it)
	22 },

	23 {

	24 "type": "integer",

	25 "name": "guestInstanceId",

	26 "nodoc": true

	27 },

	28 {

	29 "type": "function",

	30 "name": "callback",

	31 "optional": true,

	32 "parameters": [

	33 {

	34 "type": "integer",

	35 "name": "instanceId"

	36 }

	37 ]

	38 }

	39 ]

	40 },

	41 {

	42 "name": "denyRequest",

	43 "type": "function",

	44 "description": "Denies the embedding request made by the AppView with th e provided instance ID.",

	45 "parameters": [

	46 {

	47 "type": "integer",

	48 "name": "guestInstanceId",

	49 "nodoc": true

	50 }

	51 ]

	52 }

	53 ]

	54 }

	55 ]

	56

OLD	NEW