chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js - Issue 354483004: Implement <appview> - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(411)

My Issues | Starred Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Addressed comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/resources/extensions/app_view.js ('K') | « chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.html ('k') | chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/manifest.json » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 chrome.app.runtime.onLaunched.addListener(function() {	5 chrome.app.runtime.onAppEmbeddingRequest.addListener(function(request) {

6 chrome.app.window.create('index.html', {});	6 request.allow('main.html');
	lazyboy 2014/07/08 18:24:34 what happens if we call request.deny() right after what happens if we call request.deny() right after this line, etc? Fady Samuel 2014/07/08 20:23:46 Nothing. The first call works, the second is disca Show quoted text On 2014/07/08 18:24:34, lazyboy wrote: > what happens if we call request.deny() right after this line, etc? Nothing. The first call works, the second is discarded, for now. In a future CL, I'd like to enforce the same semantics as the <webview> permission API, but I'd like to limit complexity in this patch. It's already pushing 1000 lines.
7 });	7 });

	8

OLD	NEW

« chrome/renderer/resources/extensions/app_view.js ('K') | « chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.html ('k') | chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/manifest.json » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')

Powered by Google App Engine

This is Rietveld 408576698