Clarify FullscreenElementStack::addDocumentToFullScreenChangeEventQueue

Clarify FullscreenElementStack::addDocumentToFullScreenChangeEventQueue

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177197

[philipj_slow, 2014-06-29 00:50:05]

PTAL.

I had a hard time understanding on which target the event is fired and why. This
makes it a tiny bit less confusing. I also have a change that basically inlines
addDocumentToFullScreenChangeEventQueue at the 4 call sites, since in 3 of them
the target is always the same, and only in the 4th is it actually possible that
either an Element or a Document will be used. Would you be interested in that
change?

[philipj_slow, 2014-06-29 00:54:27]

On 2014/06/29 00:50:05, philipj wrote:
> PTAL.
> 
> I had a hard time understanding on which target the event is fired and why.
This
> makes it a tiny bit less confusing. I also have a change that basically
inlines
> addDocumentToFullScreenChangeEventQueue at the 4 call sites, since in 3 of
them
> the target is always the same, and only in the 4th is it actually possible
that
> either an Element or a Document will be used. Would you be interested in that
> change?

https://codereview.chromium.org/354403002/ is it and conflicts, so at most one
of these should land.

[falken, 2014-06-30 02:30:51]

On 2014/06/29 00:54:27, philipj wrote:
> On 2014/06/29 00:50:05, philipj wrote:
> > PTAL.
> > 
> > I had a hard time understanding on which target the event is fired and why.
> This
> > makes it a tiny bit less confusing. I also have a change that basically
> inlines
> > addDocumentToFullScreenChangeEventQueue at the 4 call sites, since in 3 of
> them
> > the target is always the same, and only in the 4th is it actually possible
> that
> > either an Element or a Document will be used. Would you be interested in
that
> > change?
> 
> https://codereview.chromium.org/354403002/ is it and conflicts, so at most one
> of these should land.

This change lgtm

[philipj_slow, 2014-06-30 08:27:31]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-06-30 08:28:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/354393002/1

[commit-bot: I haz the power, 2014-06-30 08:31:30]

Change committed as 177197