Move attributes-related API from UniqueElementData to AttributeCollection

Source/core/dom/ElementData.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2014 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 148 matching lines @@
 // or gains presentation attribute style (ex. width="10"). It does not need to
 // be created to fill in values in the ElementData that are derived from
 // attributes. For example populating the m_inlineStyle from the style attribute
 // doesn't require a UniqueElementData as all elements with the same style
 // attribute will have the same inline style.
 class UniqueElementData FINAL : public ElementData {
 public:
     static PassRefPtrWillBeRawPtr<UniqueElementData> create();
     PassRefPtrWillBeRawPtr<ShareableElementData> makeShareableCopy() const;
 
-    // These functions do no error/duplicate checking.
-    void appendAttribute(const QualifiedName&, const AtomicString&);
-    void removeAttributeAt(size_t index);
-
+    MutableAttributeCollection attributes();
     AttributeCollection attributes() const;
 
-    Attribute& attributeAt(unsigned index);
-    Attribute* findAttributeByName(const QualifiedName&);
-
     UniqueElementData();
     explicit UniqueElementData(const ShareableElementData&);
     explicit UniqueElementData(const UniqueElementData&);
 
     void traceAfterDispatch(Visitor*);
 
     // FIXME: We might want to support sharing element data for elements with
     // presentation attribute style. Lots of table cells likely have the same
     // attributes. Most modern pages don't use presentation attributes though
     // so this might not make sense.
     mutable RefPtrWillBeMember<StylePropertySet> m_presentationAttributeStyle;
-    Vector<Attribute, 4> m_attributeVector;
+    AttributeVector m_attributeVector;
 };
 
 DEFINE_ELEMENT_DATA_TYPE_CASTS(UniqueElementData, data->isUnique(), data.isUnique());
 
 #if !ENABLE(OILPAN)
 inline void ElementData::deref()
 {
     if (!derefBase())
         return;
     destroy();
@@ skipping 17 matching lines @@
 inline AttributeCollection ShareableElementData::attributes() const
 {
     return AttributeCollection(m_attributeArray, m_arraySize);
 }
 
 inline AttributeCollection UniqueElementData::attributes() const
 {
     return AttributeCollection(m_attributeVector.data(), m_attributeVector.size());
 }
 
-inline void UniqueElementData::appendAttribute(const QualifiedName& attributeName, const AtomicString& value)
+inline MutableAttributeCollection UniqueElementData::attributes()
 {
-    m_attributeVector.append(Attribute(attributeName, value));
-}
-
-inline void UniqueElementData::removeAttributeAt(size_t index)
-{
-    m_attributeVector.remove(index);
-}
-
-inline Attribute& UniqueElementData::attributeAt(unsigned index)
-{
-    return m_attributeVector.at(index);
+    return MutableAttributeCollection(m_attributeVector);
 }
 
 } // namespace blink
 
 #endif // ElementData_h