Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: Source/bindings/core/v8/Dictionary.h

Issue 354333002: Add path option(path2d) for hit regions on canvas2d. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: nit and rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 class Element; 48 class Element;
49 class LocalDOMWindow; 49 class LocalDOMWindow;
50 class Gamepad; 50 class Gamepad;
51 class MediaStream; 51 class MediaStream;
52 class HeaderMap; 52 class HeaderMap;
53 class Headers; 53 class Headers;
54 class IDBKeyRange; 54 class IDBKeyRange;
55 class MIDIPort; 55 class MIDIPort;
56 class MediaKeyError; 56 class MediaKeyError;
57 class Notification; 57 class Notification;
58 class Path2D;
58 class SpeechRecognitionResult; 59 class SpeechRecognitionResult;
59 class SpeechRecognitionResultList; 60 class SpeechRecognitionResultList;
60 class Storage; 61 class Storage;
61 class TrackBase; 62 class TrackBase;
62 class VoidCallback; 63 class VoidCallback;
63 64
64 class Dictionary { 65 class Dictionary {
65 ALLOW_ONLY_INLINE_ALLOCATION(); 66 ALLOW_ONLY_INLINE_ALLOCATION();
66 public: 67 public:
67 Dictionary(); 68 Dictionary();
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 bool convert(ConversionContext&, const String&, PointerType<T>&) const; 174 bool convert(ConversionContext&, const String&, PointerType<T>&) const;
174 175
175 template<typename StringType> 176 template<typename StringType>
176 bool getStringType(const String&, StringType&) const; 177 bool getStringType(const String&, StringType&) const;
177 178
178 bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const; 179 bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;
179 bool getOwnPropertyNames(Vector<String>&) const; 180 bool getOwnPropertyNames(Vector<String>&) const;
180 181
181 bool getWithUndefinedOrNullCheck(const String&, String&) const; 182 bool getWithUndefinedOrNullCheck(const String&, String&) const;
182 bool getWithUndefinedOrNullCheck(const String&, RefPtrWillBeMember<Element>& ) const; 183 bool getWithUndefinedOrNullCheck(const String&, RefPtrWillBeMember<Element>& ) const;
184 bool getWithUndefinedOrNullCheck(const String&, RefPtr<Path2D>&) const;
183 185
184 bool hasProperty(const String&) const; 186 bool hasProperty(const String&) const;
185 187
186 private: 188 private:
187 bool getKey(const String& key, v8::Local<v8::Value>&) const; 189 bool getKey(const String& key, v8::Local<v8::Value>&) const;
188 190
189 v8::Handle<v8::Value> m_options; 191 v8::Handle<v8::Value> m_options;
190 v8::Isolate* m_isolate; 192 v8::Isolate* m_isolate;
191 }; 193 };
192 194
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value)) 346 if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
345 return true; 347 return true;
346 348
347 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type.")); 349 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type."));
348 return false; 350 return false;
349 } 351 }
350 352
351 } 353 }
352 354
353 #endif // Dictionary_h 355 #endif // Dictionary_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/canvas/canvas-hit-regions-path2d-transform-test-expected.txt ('k') | Source/bindings/core/v8/Dictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698