Source/core/dom/custom/CustomElement.cpp - Issue 35423004: Move SVGNames to Python

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/custom/CustomElement.cpp

Issue 35423004: Move SVGNames to Python (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address reviewer feedback Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/custom/CustomElement.cpp

diff --git a/Source/core/dom/custom/CustomElement.cpp b/Source/core/dom/custom/CustomElement.cpp

index a2a150cc0d57e7c56f0dcd2b9e9b980c99114a42..b4e509df66ed8e2b0fc029a6e358233a30b8022e 100644

--- a/Source/core/dom/custom/CustomElement.cpp

+++ b/Source/core/dom/custom/CustomElement.cpp

@@ -71,7 +71,7 @@ bool CustomElement::isValidName(const AtomicString& name, NameSet validNames)

DEFINE_STATIC_LOCAL(Vector<AtomicString>, reservedNames, ());

if (reservedNames.isEmpty()) {

reservedNames.append(MathMLNames::annotation_xmlTag.localName());

- reservedNames.append(SVGNames::color_profileTag.localName());

+ reservedNames.append("color-profile");

eseidel 2013/10/23 18:16:10 You should just add a comment.

reservedNames.append(SVGNames::font_faceTag.localName());

reservedNames.append(SVGNames::font_face_srcTag.localName());

reservedNames.append(SVGNames::font_face_uriTag.localName());

« no previous file with comments | « Source/core/core_derived_sources.gyp ('k') | Source/core/svg/SVGTagNames.in » ('j') | no next file with comments »