Move SVGNames to Python

Move SVGNames to Python

This CL removes the dependency on make_names.pl from SVG. After this CL, there
is only one more client of make_names.pl to remove.

R=eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160366

[eseidel, 2013-10-23 07:17:26]

I don't like the interfaceName=Element realy-means "HTMLElement" change.  But
otherwise this looks good.

https://codereview.chromium.org/35423004/diff/1/Source/build/scripts/template...
File Source/build/scripts/templates/ElementFactory.cpp.tmpl (right):

https://codereview.chromium.org/35423004/diff/1/Source/build/scripts/template...
Source/build/scripts/templates/ElementFactory.cpp.tmpl:56: 
the form element during construction thing is wonky.

https://codereview.chromium.org/35423004/diff/1/Source/core/dom/custom/Custom...
File Source/core/dom/custom/CustomElement.cpp (right):

https://codereview.chromium.org/35423004/diff/1/Source/core/dom/custom/Custom...
Source/core/dom/custom/CustomElement.cpp:74: 
?

https://codereview.chromium.org/35423004/diff/1/Source/core/html/HTMLTagNames.in
File Source/core/html/HTMLTagNames.in (right):

https://codereview.chromium.org/35423004/diff/1/Source/core/html/HTMLTagNames...
Source/core/html/HTMLTagNames.in:7: address interfaceName=HTMLElement
Why not be explicit about the namespacing?  This feels very weird.

[abarth-chromium, 2013-10-23 17:19:15]

Thanks for the review!

https://codereview.chromium.org/35423004/diff/1/Source/build/scripts/template...
File Source/build/scripts/templates/ElementFactory.cpp.tmpl (right):

https://codereview.chromium.org/35423004/diff/1/Source/build/scripts/template...
Source/build/scripts/templates/ElementFactory.cpp.tmpl:56: 
On 2013/10/23 07:17:26, eseidel wrote:
> the form element during construction thing is wonky.

Yes.  It's apparently needed for HTML due to the magic form association
behavior.

https://codereview.chromium.org/35423004/diff/1/Source/core/dom/custom/Custom...
File Source/core/dom/custom/CustomElement.cpp (right):

https://codereview.chromium.org/35423004/diff/1/Source/core/dom/custom/Custom...
Source/core/dom/custom/CustomElement.cpp:74: 
On 2013/10/23 07:17:26, eseidel wrote:
> ?

We don't implement the <svg:color-profile> element.  Previously the code what
#if 0 in the in file, which caused the element factory to ignore the name but
SVGNames to include it.

This is the only use of the string in the codebase.  Rather than make the string
appear in SVGNames but not in SVGElementFactory, I thought it would be better to
just use a normal string literal here.  I can add a comment if you think that
would be helpful.  I can also a "omitElementFactory" attribute to the in file to
make the tag appear in SVGNames but not in SVGElementFactory.

https://codereview.chromium.org/35423004/diff/1/Source/core/html/HTMLTagNames.in
File Source/core/html/HTMLTagNames.in (right):

https://codereview.chromium.org/35423004/diff/1/Source/core/html/HTMLTagNames...
Source/core/html/HTMLTagNames.in:7: address interfaceName=HTMLElement
On 2013/10/23 07:17:26, eseidel wrote:
> Why not be explicit about the namespacing?  This feels very weird.

I did it to simplify something in the code generator.  I agree that it's ugly
here.  I'll try another approach.

[abarth-chromium, 2013-10-23 18:13:27]

I've attempted to address your comments.

[eseidel, 2013-10-23 18:16:10]

lgtm

https://codereview.chromium.org/35423004/diff/140001/Source/core/dom/custom/C...
File Source/core/dom/custom/CustomElement.cpp (right):

https://codereview.chromium.org/35423004/diff/140001/Source/core/dom/custom/C...
Source/core/dom/custom/CustomElement.cpp:74:
reservedNames.append("color-profile");
You should just add a comment.

[commit-bot: I haz the power, 2013-10-23 18:17:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/35423004/140001

[commit-bot: I haz the power, 2013-10-23 18:23:26]

Failed to trigger a try job on win_layout
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-10-23 18:23:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/35423004/210001

[abarth-chromium, 2013-10-23 19:39:34]

Committed patchset #3 manually as r160366 (presubmit successful).