Issue 354223002: Add methods to RenderLayer to get at the painting or scrolling graphics layers, if present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354223002: Add methods to RenderLayer to get at the painting or scrolling graphics layers, if present. (Closed)

Created:
6 years, 5 months ago by chrishtr

Modified:
6 years, 5 months ago

Reviewers:
Ian Vollick, abarth-chromium

CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Add methods to RenderLayer to get at the painting or scrolling graphics layers, if present. This lets us remove code elsewhere that did the same thing, but potentially incorrectly and with unnecessary knowledge of squashing. BUG=384520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177158

Patch Set 1 #

Patch Set 2 : Edited comments. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -20 lines)			Patch
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View		1 chunk	+1 line, -10 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	Source/web/LinkHighlight.cpp	View		1 chunk	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/354223002/20001

6 years, 5 months ago (2014-06-27 22:01:39 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 5 months ago (2014-06-27 23:06:15 UTC) #5

Message was sent while issue was closed.

Change committed as 177158

Expand Messages | Collapse Messages