Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3332)

Unified Diff: Source/modules/webaudio/BiquadDSPKernel.h

Issue 354213002: Initialize value since calculateFinalValues may fail to do so. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioParam.cpp ('k') | Source/modules/webaudio/BiquadDSPKernel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/BiquadDSPKernel.h
diff --git a/Source/modules/webaudio/BiquadDSPKernel.h b/Source/modules/webaudio/BiquadDSPKernel.h
index 528a8ea7ccac7db168d640f6843de94271529e1d..d0b12b332f005d283c54e7c10b7ea8a5733c5dbe 100644
--- a/Source/modules/webaudio/BiquadDSPKernel.h
+++ b/Source/modules/webaudio/BiquadDSPKernel.h
@@ -62,12 +62,13 @@ protected:
// To prevent audio glitches when parameters are changed,
// dezippering is used to slowly change the parameters.
- // |useSmoothing| implies that we want to update using the
- // smoothed values. Otherwise the final target values are
- // used. If |forceUpdate| is true, we update the coefficients even
- // if they are not dirty. (Used when computing the frequency
- // response.)
- void updateCoefficientsIfNecessary(bool useSmoothing, bool forceUpdate);
+ void updateCoefficientsIfNecessary();
+ // Update the biquad cofficients with the given parameters
+ void updateCoefficients(double frequency, double Q, double gain, double detune);
+
+private:
+ // Synchronize process() with getting and setting the filter coefficients.
+ mutable Mutex m_processLock;
};
} // namespace WebCore
« no previous file with comments | « Source/modules/webaudio/AudioParam.cpp ('k') | Source/modules/webaudio/BiquadDSPKernel.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698