Issue 354133004: Revert of Fix race condition in parallel font initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354133004: Revert of Fix race condition in parallel font initialization. (Closed)

Created:
6 years, 5 months ago by mtklein

Modified:
6 years, 5 months ago

Reviewers:
bungeman-skia, Tom Hudson, reed1, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Fix race condition in parallel font initialization. (https://codereview.chromium.org/355573006/) Reason for revert: canaries still slightly broken Original issue's description: > Fix race condition in parallel font initialization. > > Uses a mutex to guard construction of the singleton, which initialies > the non-threadsafe libfontconfig. Without this change, the parallel > path ops test runner crashes 6/10 and hangs 2/10 on startup; with this > change, 0/10 problems. > > BUG=skia:2693 > R=mtklein@google.com,bungeman@google.com > > Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8 > > Committed: https://skia.googlesource.com/skia/+/60b08a0adfe73f593af62c8d3f55958438360e1b TBR=bungeman@google.com,reed@google.com,tomhudson@google.com,tomhudson@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2693 Committed: https://skia.googlesource.com/skia/+/e41f3886ead65550cdbfa99b8f4b7c1831ec3221

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -14 lines)			Patch
M	include/ports/SkFontConfigInterface.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/ports/SkFontConfigInterface_android.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ports/SkFontConfigInterface_direct.cpp	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/ports/SkFontHost_fontconfig.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Fix race condition in parallel font initialization.

6 years, 5 months ago (2014-07-01 20:32:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/354133004/1

6 years, 5 months ago (2014-07-01 20:33:29 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-01 20:33:37 UTC) #3

Message was sent while issue was closed.

Change committed as e41f3886ead65550cdbfa99b8f4b7c1831ec3221