Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: src/x64/macro-assembler-x64.h

Issue 35413006: Correct handling of arrays with callbacks in the prototype chain. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Bugfix: check on dictionary elements was incorrect. Added test. Re-enabled test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/ic-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1394 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 void JumpIfJSArrayHasAllocationMemento(Register receiver_reg, 1405 void JumpIfJSArrayHasAllocationMemento(Register receiver_reg,
1406 Register scratch_reg, 1406 Register scratch_reg,
1407 Label* memento_found) { 1407 Label* memento_found) {
1408 Label no_memento_found; 1408 Label no_memento_found;
1409 TestJSArrayForAllocationMemento(receiver_reg, scratch_reg, 1409 TestJSArrayForAllocationMemento(receiver_reg, scratch_reg,
1410 &no_memento_found); 1410 &no_memento_found);
1411 j(equal, memento_found); 1411 j(equal, memento_found);
1412 bind(&no_memento_found); 1412 bind(&no_memento_found);
1413 } 1413 }
1414 1414
1415 // Jumps to found label if a prototype map has dictionary elements.
1416 void JumpIfDictionaryInPrototypeChain(Register object, Register scratch0,
1417 Register scratch1, Label* found);
1418
1415 private: 1419 private:
1416 // Order general registers are pushed by Pushad. 1420 // Order general registers are pushed by Pushad.
1417 // rax, rcx, rdx, rbx, rsi, rdi, r8, r9, r11, r14, r15. 1421 // rax, rcx, rdx, rbx, rsi, rdi, r8, r9, r11, r14, r15.
1418 static const int kSafepointPushRegisterIndices[Register::kNumRegisters]; 1422 static const int kSafepointPushRegisterIndices[Register::kNumRegisters];
1419 static const int kNumSafepointSavedRegisters = 11; 1423 static const int kNumSafepointSavedRegisters = 11;
1420 static const int kSmiShift = kSmiTagSize + kSmiShiftSize; 1424 static const int kSmiShift = kSmiTagSize + kSmiShiftSize;
1421 1425
1422 bool generating_stub_; 1426 bool generating_stub_;
1423 bool allow_stub_calls_; 1427 bool allow_stub_calls_;
1424 bool has_frame_; 1428 bool has_frame_;
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
1588 masm->popfq(); \ 1592 masm->popfq(); \
1589 } \ 1593 } \
1590 masm-> 1594 masm->
1591 #else 1595 #else
1592 #define ACCESS_MASM(masm) masm-> 1596 #define ACCESS_MASM(masm) masm->
1593 #endif 1597 #endif
1594 1598
1595 } } // namespace v8::internal 1599 } } // namespace v8::internal
1596 1600
1597 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_ 1601 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/x64/ic-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698