Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 35413006: Correct handling of arrays with callbacks in the prototype chain. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Bugfix: check on dictionary elements was incorrect. Added test. Re-enabled test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 void JumpIfJSArrayHasAllocationMemento(Register receiver_reg, 968 void JumpIfJSArrayHasAllocationMemento(Register receiver_reg,
969 Register scratch_reg, 969 Register scratch_reg,
970 Label* memento_found) { 970 Label* memento_found) {
971 Label no_memento_found; 971 Label no_memento_found;
972 TestJSArrayForAllocationMemento(receiver_reg, scratch_reg, 972 TestJSArrayForAllocationMemento(receiver_reg, scratch_reg,
973 &no_memento_found); 973 &no_memento_found);
974 j(equal, memento_found); 974 j(equal, memento_found);
975 bind(&no_memento_found); 975 bind(&no_memento_found);
976 } 976 }
977 977
978 // Jumps to found label if a prototype map has dictionary elements.
979 void JumpIfDictionaryInPrototypeChain(Register object, Register scratch0,
980 Register scratch1, Label* found);
981
978 private: 982 private:
979 bool generating_stub_; 983 bool generating_stub_;
980 bool allow_stub_calls_; 984 bool allow_stub_calls_;
981 bool has_frame_; 985 bool has_frame_;
982 // This handle will be patched with the code object on installation. 986 // This handle will be patched with the code object on installation.
983 Handle<Object> code_object_; 987 Handle<Object> code_object_;
984 988
985 // Helper functions for generating invokes. 989 // Helper functions for generating invokes.
986 void InvokePrologue(const ParameterCount& expected, 990 void InvokePrologue(const ParameterCount& expected,
987 const ParameterCount& actual, 991 const ParameterCount& actual,
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1114 } \ 1118 } \
1115 masm-> 1119 masm->
1116 #else 1120 #else
1117 #define ACCESS_MASM(masm) masm-> 1121 #define ACCESS_MASM(masm) masm->
1118 #endif 1122 #endif
1119 1123
1120 1124
1121 } } // namespace v8::internal 1125 } } // namespace v8::internal
1122 1126
1123 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 1127 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698