Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/arm/macro-assembler-arm.h

Issue 35413006: Correct handling of arrays with callbacks in the prototype chain. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Bugfix: check on dictionary elements was incorrect. Added test. Re-enabled test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1376 matching lines...) Expand 10 before | Expand all | Expand 10 after
1387 void JumpIfJSArrayHasAllocationMemento(Register receiver_reg, 1387 void JumpIfJSArrayHasAllocationMemento(Register receiver_reg,
1388 Register scratch_reg, 1388 Register scratch_reg,
1389 Label* memento_found) { 1389 Label* memento_found) {
1390 Label no_memento_found; 1390 Label no_memento_found;
1391 TestJSArrayForAllocationMemento(receiver_reg, scratch_reg, 1391 TestJSArrayForAllocationMemento(receiver_reg, scratch_reg,
1392 &no_memento_found); 1392 &no_memento_found);
1393 b(eq, memento_found); 1393 b(eq, memento_found);
1394 bind(&no_memento_found); 1394 bind(&no_memento_found);
1395 } 1395 }
1396 1396
1397 // Jumps to found label if a prototype map has dictionary elements.
1398 void JumpIfDictionaryInPrototypeChain(Register object, Register scratch0,
1399 Register scratch1, Label* found);
1400
1397 private: 1401 private:
1398 void CallCFunctionHelper(Register function, 1402 void CallCFunctionHelper(Register function,
1399 int num_reg_arguments, 1403 int num_reg_arguments,
1400 int num_double_arguments); 1404 int num_double_arguments);
1401 1405
1402 void Jump(intptr_t target, RelocInfo::Mode rmode, Condition cond = al); 1406 void Jump(intptr_t target, RelocInfo::Mode rmode, Condition cond = al);
1403 1407
1404 // Helper functions for generating invokes. 1408 // Helper functions for generating invokes.
1405 void InvokePrologue(const ParameterCount& expected, 1409 void InvokePrologue(const ParameterCount& expected,
1406 const ParameterCount& actual, 1410 const ParameterCount& actual,
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
1509 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__) 1513 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
1510 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm-> 1514 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
1511 #else 1515 #else
1512 #define ACCESS_MASM(masm) masm-> 1516 #define ACCESS_MASM(masm) masm->
1513 #endif 1517 #endif
1514 1518
1515 1519
1516 } } // namespace v8::internal 1520 } } // namespace v8::internal
1517 1521
1518 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_ 1522 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698