Issue 35413005: Using instrumented.identity.onSignInChanged to track signed-in state changes

Issue 35413005: Using instrumented.identity.onSignInChanged to track signed-in state changes (Closed)

Created:
7 years, 2 months ago by vadimt

Modified:
7 years, 2 months ago

Reviewers:
robliao, rgustafson, skare_

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Using instrumented.identity.onSignInChanged to track signed-in state changes. BUG=164227 TEST=No Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230910

Patch Set 2 : Restoring polling #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	chrome/browser/resources/google_now/utility.js	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
	M	chrome/browser/resources/google_now/utility_test_util.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robliao

LGTM with one question. https://codereview.chromium.org/35413005/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (right): https://codereview.chromium.org/35413005/diff/1/chrome/browser/resources/google_now/utility.js#newcode693 chrome/browser/resources/google_now/utility.js:693: // problem with the token. ...

7 years, 2 months ago (2013-10-23 17:11:48 UTC) #2

vadimt

I was in conversations with identity people, and they told that it may happen that ...

7 years, 2 months ago (2013-10-24 19:52:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/35413005/60001

7 years, 2 months ago (2013-10-24 20:24:25 UTC) #5

Message was sent while issue was closed.

Change committed as 230910

Expand Messages | Collapse Messages