Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 354123002: Web Animations: Don't eagerly assign start times for element.animate (Closed)

Created:
6 years, 6 months ago by dstockwell
Modified:
6 years, 6 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Web Animations: Don't eagerly assign start times for element.animate This ensure that animations started by element.animate function the same way as regular CSS Animations -- they will wait for notification of a start time from the compositor. BUG=389396 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/animation/AnimationTimeline.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dstockwell
6 years, 6 months ago (2014-06-27 02:32:49 UTC) #1
Timothy Loh
lgtm
6 years, 6 months ago (2014-06-27 03:38:36 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 6 months ago (2014-06-27 03:42:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/354123002/1
6 years, 6 months ago (2014-06-27 03:44:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-27 05:23:13 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 06:00:19 UTC) #6
Message was sent while issue was closed.
Change committed as 177071

Powered by Google App Engine
This is Rietveld 408576698