Set a fixed layout size only if the container view has a WRAP_CONTENT layout mode.

Set a fixed layout size only if the container view has a WRAP_CONTENT layout mode.

Using the measureSpec from the onMeasure callback to decide whether to set a
fixed layout size or not has proven to be a bit unpredictable. Changing the
code to look at the LayoutParams instead.

BUG=None
TEST=AndroidWebViewTest
// android_webview-only, trybots were happy.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231815

[mkosiba (inactive), 2013-10-22 15:23:59]

PTAL

[benm (inactive), 2013-10-22 15:39:06]

thanks Martin, sounds good. Just some clarification on the big comment I think

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
File android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java
(right):

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:231: //
the viewport size cannot be directly calculated from the size as that can result
in the
from the size - which size?

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:232: //
layout being unstable or unpredictable.
can you elaborate a little in the comment on what you mean by unstable?

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:233: //
If both the width and height are fixed (specified by the parent) then content
size
parent View

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:236: //
We assume the width is 'fixed' if the parent container specified an EXACT or an
AT_MOST
parent View

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:244: //
(LinearLayout with a WRAP_CONTENT height, for example) can result onMeasure
calls with
can result in

[mkosiba (inactive), 2013-10-22 17:27:15]

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
File android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java
(right):

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:231: //
the viewport size cannot be directly calculated from the size as that can result
in the
On 2013/10/22 15:39:06, benm wrote:
> from the size - which size?

Done.

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:232: //
layout being unstable or unpredictable.
On 2013/10/22 15:39:06, benm wrote:
> can you elaborate a little in the comment on what you mean by unstable?

Done.

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:233: //
If both the width and height are fixed (specified by the parent) then content
size
On 2013/10/22 15:39:06, benm wrote:
> parent View

Done.

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:236: //
We assume the width is 'fixed' if the parent container specified an EXACT or an
AT_MOST
On 2013/10/22 15:39:06, benm wrote:
> parent View

Done.

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:244: //
(LinearLayout with a WRAP_CONTENT height, for example) can result onMeasure
calls with
On 2013/10/22 15:39:06, benm wrote:
> can result in 

Done.

https://codereview.chromium.org/35403002/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java:244: //
(LinearLayout with a WRAP_CONTENT height, for example) can result onMeasure
calls with
On 2013/10/22 15:39:06, benm wrote:
> can result in 

Done.

[benm (inactive), 2013-10-24 14:42:50]

lgtm

Thanks, that comment is much clearer now.

[commit-bot: I haz the power, 2013-10-30 11:46:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/35403002/90001

[commit-bot: I haz the power, 2013-10-30 11:47:22]

Change committed as 231815