Move attributes-related methods from ElementData to AttributeCollection

Move attributes-related methods from ElementData to AttributeCollection

Move attributes-related methods from ElementData to AttributeCollection.
Now that we have a dedicated class for Element attributes, it seems odd for
the attributes-related API to be in Element / ElementData.

This CL does not change the Element API for attributes so that the patch
stays small. However, the idea would be to later move callers away from the
attributes API on Element and instead call Element::attributes() and then
interact directly with the returned AttributeCollection object.

Using AttributeCollection directly has the benefit of avoiding redundant
calls to ElementData::isUnique() and the caller can store AttributeCollection
object in a variable and then any later interaction with this object won't
require checking if ElementData is unique or not.

R=esprehn@chromium.org, adamk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177041

[esprehn, 2014-06-26 22:03:58]

AttributeCollection should be in it's own file.

https://codereview.chromium.org/354023008/diff/20001/Source/core/dom/ElementD...
File Source/core/dom/ElementData.h (right):

https://codereview.chromium.org/354023008/diff/20001/Source/core/dom/ElementD...
Source/core/dom/ElementData.h:67: size_t find(Attr*) const;
We're going to have to be really careful here, originally it was called
findByName because get() does a linear search and get() methods are usually
assumed to be cheap while find() implies more work. We can see how this shakes
out though.

[Inactive, 2014-06-26 22:16:40]

https://codereview.chromium.org/354023008/diff/20001/Source/core/dom/ElementD...
File Source/core/dom/ElementData.h (right):

https://codereview.chromium.org/354023008/diff/20001/Source/core/dom/ElementD...
Source/core/dom/ElementData.h:47: class AttributeCollection {
Ok, I'll move this to a separate file since it is getting bigger.

https://codereview.chromium.org/354023008/diff/20001/Source/core/dom/ElementD...
Source/core/dom/ElementData.h:67: size_t find(Attr*) const;
On 2014/06/26 22:03:58, esprehn wrote:
> We're going to have to be really careful here, originally it was called
> findByName because get() does a linear search and get() methods are usually
> assumed to be cheap while find() implies more work. We can see how this shakes
> out though.

To be fair, they were called getAttributeItem() / getAttributeItemIndex() before
I renamed them to find*ByName() a couple of week ago :)

However, I totally agree. I did not think about this but the name should
definitely reflect that the implementation is actually doing work (linear search
in this case). I'll propose a better naming.

[Inactive, 2014-06-27 00:22:30]

On 2014/06/26 22:03:58, esprehn wrote:
> AttributeCollection should be in it's own file.
> 
>
https://codereview.chromium.org/354023008/diff/20001/Source/core/dom/ElementD...
> File Source/core/dom/ElementData.h (right):
> 
>
https://codereview.chromium.org/354023008/diff/20001/Source/core/dom/ElementD...
> Source/core/dom/ElementData.h:67: size_t find(Attr*) const;
> We're going to have to be really careful here, originally it was called
> findByName because get() does a linear search and get() methods are usually
> assumed to be cheap while find() implies more work. We can see how this shakes
> out though.

I took your feedback into consideration in the latest patchset. Please take
another look when you get a chance.
I went with find() / findIndex() for the naming. Feel free to suggest something
better :)

[esprehn, 2014-06-27 00:37:05]

lgtm

[Inactive, 2014-06-27 00:39:25]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-27 00:40:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/354023008/40001

[commit-bot: I haz the power, 2014-06-27 01:41:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[commit-bot: I haz the power, 2014-06-27 01:54:59]

Change committed as 177041