DevTools: disable DOMAgent when profiler is active

DevTools: disable DOMAgent when profiler is active

BUG=381115
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177102

[pfeldman, 2014-06-26 13:57:17]

https://codereview.chromium.org/354023002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorDOMAgent.cpp (right):

https://codereview.chromium.org/354023002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorDOMAgent.cpp:496: restore();
This seems wrong: getDocument -> enable -> restore -> setDocument.

https://codereview.chromium.org/354023002/diff/1/Source/devtools/front_end/sd...
File Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/354023002/diff/1/Source/devtools/front_end/sd...
Source/devtools/front_end/sdk/DOMModel.js:931: this._agent.enable();
Lets make ::enable call ::setDocument unless it comes from ::getDocument on
backend.

[loislo, 2014-06-26 14:21:41]

comments addressed

[pfeldman, 2014-06-26 15:15:15]

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorDOMAgent.cpp (right):

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMAgent.cpp:492: restore();
restore should call innerEnable instead, enable(ErrorString) should not call
restore.

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorDOMAgent.h (right):

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMAgent.h:220: void enable();
innerEnable

[loislo, 2014-06-26 18:27:05]

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorDOMAgent.cpp (right):

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMAgent.cpp:492: restore();
On 2014/06/26 15:15:15, pfeldman wrote:
> restore should call innerEnable instead, enable(ErrorString) should not call
> restore.

In that case enable call wouldn't send the documentUpdate message to the
frontend (it was the idea of the patch)

Also call innerEnable from restore would change the existing behavior.
i.e.
1) user opened profiler panel
2) user started a profile (DOM agent was disabled)
3) user navigated the page. (restore was called and the agent was enabled when
profiler was active)

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorDOMAgent.h (right):

https://codereview.chromium.org/354023002/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMAgent.h:220: void enable();
On 2014/06/26 15:15:15, pfeldman wrote:
> innerEnable

Done.

[loislo, 2014-06-27 11:19:35]

comments addressed

[pfeldman, 2014-06-27 11:35:23]

https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
File Source/core/inspector/InspectorDOMAgent.cpp (right):

https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMAgent.cpp:279: if (!enabled())
restore should always be

if (m_state->getBoolean(DOMAgentState::domAgentEnabled))
    innerEnable();

https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMAgent.cpp:493: if (enabled())
innerEnable should not check for enabled, enable should.

https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMAgent.cpp:504:
setDocument(m_pageAgent->mainFrame()->document());
This should be a part of innerEnable.

[loislo, 2014-06-27 12:10:54]

On 2014/06/27 11:35:23, pfeldman wrote:
>
https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
> File Source/core/inspector/InspectorDOMAgent.cpp (right):
> 
>
https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
> Source/core/inspector/InspectorDOMAgent.cpp:279: if (!enabled())
> restore should always be
> 
> if (m_state->getBoolean(DOMAgentState::domAgentEnabled))
>     innerEnable();
> 
>
https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
> Source/core/inspector/InspectorDOMAgent.cpp:493: if (enabled())
> innerEnable should not check for enabled, enable should.
> 
>
https://codereview.chromium.org/354023002/diff/60001/Source/core/inspector/In...
> Source/core/inspector/InspectorDOMAgent.cpp:504:
> setDocument(m_pageAgent->mainFrame()->document());
> This should be a part of innerEnable.

comments addressed

[pfeldman, 2014-06-27 12:16:45]

lgtm

[loislo, 2014-06-27 12:26:25]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2014-06-27 12:27:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/loislo@chromium.org/354023002/100001

[commit-bot: I haz the power, 2014-06-27 13:33:04]

Change committed as 177102