DevTools: [Console] fix search to reveal matched messages

Source/devtools/front_end/console/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 858 matching lines @@
     elementsToRestoreScrollPositionsFor: function()
     {
         return [this._messagesElement];
     },
 
     searchCanceled: function()
     {
         this._clearCurrentSearchResultHighlight();
         delete this._searchResults;
         delete this._searchRegex;
+        this._viewport.refresh();
     },
 
     /**
      * @param {string} query
      * @param {boolean} shouldJump
      * @param {boolean=} jumpBackwards
      */
     performSearch: function(query, shouldJump, jumpBackwards)
     {
         this.searchCanceled();
         this._searchableView.updateSearchMatchesCount(0);
         this._searchRegex = createPlainTextSearchRegex(query, "gi");
 
+        /** @type {!Array.<number>} */
         this._searchResults = [];
         for (var i = 0; i < this._visibleViewMessages.length; i++) {
             if (this._visibleViewMessages[i].matchesRegex(this._searchRegex))
-                this._searchResults.push(this._visibleViewMessages[i]);
+                this._searchResults.push(i);
         }
         this._searchableView.updateSearchMatchesCount(this._searchResults.length);
         this._currentSearchResultIndex = -1;
         if (shouldJump && this._searchResults.length)
             this._jumpToSearchResult(jumpBackwards ? -1 : 0);
+        this._viewport.refresh();
     },
 
     jumpToNextSearchResult: function()
     {
         if (!this._searchResults || !this._searchResults.length)
             return;
         this._jumpToSearchResult(this._currentSearchResultIndex + 1);
     },
 
     jumpToPreviousSearchResult: function()
     {
         if (!this._searchResults || !this._searchResults.length)
             return;
         this._jumpToSearchResult(this._currentSearchResultIndex - 1);
     },
 
     _clearCurrentSearchResultHighlight: function()
     {
         if (!this._searchResults)
             return;
 
-        var highlightedViewMessage = this._searchResults[this._currentSearchResultIndex];
+        var highlightedViewMessage = this._visibleViewMessages[this._searchResults[this._currentSearchResultIndex]];
         if (highlightedViewMessage)
             highlightedViewMessage.clearHighlight();
         this._currentSearchResultIndex = -1;
     },
 
     _jumpToSearchResult: function(index)
     {
         index = mod(index, this._searchResults.length);
         this._clearCurrentSearchResultHighlight();
         this._currentSearchResultIndex = index;
         this._searchableView.updateCurrentMatchIndex(this._currentSearchResultIndex);
-        this._searchResults[index].highlightSearchResults(this._searchRegex);
+        var currentViewMessageIndex = this._searchResults[index];
+        this._viewport.scrollItemIntoView(currentViewMessageIndex);
+        this._visibleViewMessages[currentViewMessageIndex].highlightSearchResults(this._searchRegex);
     },
 
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
  * @param {!WebInspector.ConsoleView} view
  */
@@ skipping 280 matching lines @@
 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = {
     /**
      * @return {boolean}
      */
     handleAction: function()
     {
         WebInspector.console.show();
         return true;
     }
 }