Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 354013002: DevTools: [Console] fix search to reveal matched messages (Closed)

Created:
6 years, 6 months ago by lushnikov
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [Console] fix search to reveal matched messages During console migration on viewport revealing search results was forgotten. This patch fixes this. BUG=388718 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177118

Patch Set 1 #

Patch Set 2 : add testcase #

Patch Set 3 : rebaseline one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -12 lines) Patch
A LayoutTests/inspector/console/console-search-reveals-messages.html View 1 1 chunk +69 lines, -0 lines 0 comments Download
A LayoutTests/inspector/console/console-search-reveals-messages-expected.txt View 1 1 chunk +212 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-viewport-selection.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-viewport-selection-expected.txt View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 4 chunks +8 lines, -3 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 2 chunks +1 line, -3 lines 0 comments Download
M Source/devtools/front_end/ui/ViewportControl.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
lushnikov
Please take a look.
6 years, 6 months ago (2014-06-26 13:33:31 UTC) #1
pfeldman
a test?
6 years, 6 months ago (2014-06-26 14:14:54 UTC) #2
lushnikov
a test!
6 years, 5 months ago (2014-06-27 11:52:16 UTC) #3
pfeldman
lgtm
6 years, 5 months ago (2014-06-27 11:52:51 UTC) #4
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 5 months ago (2014-06-27 11:53:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/354013002/20001
6 years, 5 months ago (2014-06-27 11:54:11 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-27 13:02:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 13:26:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/13651)
6 years, 5 months ago (2014-06-27 13:26:26 UTC) #9
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 5 months ago (2014-06-27 15:47:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/354013002/40001
6 years, 5 months ago (2014-06-27 15:48:11 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 17:01:06 UTC) #12
Message was sent while issue was closed. 
Change committed as 177118

Powered by Google App Engine
This is Rietveld 408576698