Fix SkTypeface::serialize() on Mac by properly indicating local fonts

Fix SkTypeface::serialize() on Mac by properly indicating local fonts

We used to always set isLocalStream to false in SkTypeface_Mac::onGetFontDescriptor(),
which caused SkTypeface::serialize() to never actually serialize fonts.

BUG=skia:2698
Committed: https://skia.googlesource.com/skia/+/26337e970201cae39f44b49546b8d9b0bc5e5c98

[caseq, 2014-06-27 09:56:44]

Please take a look -- we bumped into this problem while playing with the
DevTools' Paint Profiler that we work on, and once I tracked it down I thought I
could as well try to fix it. The support for local streams is along the lines of
SkFontHost_win implementation -- given that SkFontHost_mac::onOpenStream() seems
to be already in place, we apparently just need to plumb the localStream flag
from wherever we create the typeface.

[bungeman-skia, 2014-06-30 14:58:28]

See also https://codereview.chromium.org/13947030/ , this got derailed at some
point for some reason.

[bungeman-skia, 2014-06-30 15:10:24]

https://codereview.chromium.org/353993003/diff/20001/src/ports/SkFontHost_mac...
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/353993003/diff/20001/src/ports/SkFontHost_mac...
src/ports/SkFontHost_mac.cpp:1448: return cg ?
internalCreateTypefaceFromCTFont(ct, true) : NULL;
I think this is incorrect, in that stream based typefaces should not end up in
the cache. We actually need to clean up any existing places where we do this,
since we never actually get any hits (nor should we).

[caseq, 2014-06-30 16:27:42]

On 2014/06/30 15:10:24, bungeman1 wrote:

> See also https://codereview.chromium.org/13947030/ , this got derailed at some
> point for some reason.

Heh, looks like we've got quite decent reproducibility :-)

>
https://codereview.chromium.org/353993003/diff/20001/src/ports/SkFontHost_mac...
> File src/ports/SkFontHost_mac.cpp (right):
>
https://codereview.chromium.org/353993003/diff/20001/src/ports/SkFontHost_mac...
> src/ports/SkFontHost_mac.cpp:1448: return cg ?
> internalCreateTypefaceFromCTFont(ct, true) : NULL;
> I think this is incorrect, in that stream based typefaces should not end up in
> the cache. We actually need to clean up any existing places where we do this,
> since we never actually get any hits (nor should we).

Thanks, looks like I can just inline a call to NewFromFontRef() if I got you
right. Done.

[bungeman-skia, 2014-06-30 18:59:08]

lgtm

[bungeman-skia, 2014-06-30 18:59:23]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-06-30 18:59:47]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/caseq@chromium.org/353993003/40001

[commit-bot: I haz the power, 2014-06-30 19:14:58]

Change committed as 26337e970201cae39f44b49546b8d9b0bc5e5c98