Issue 353953002: Use simple keyed store again in ArrayPush_JS_Builtin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353953002: Use simple keyed store again in ArrayPush_JS_Builtin (Closed)

Created:
6 years, 6 months ago by Weiliang

Modified:
6 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Use simple keyed store again in ArrayPush_JS_Builtin This reverts the change of array.js in r20839 and recovers 38% performance regression of DOM-Search case in Browsermark2.0. There is no performance impact on JavaScript benchmarks (Octane, Kraken and SunSpider). BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22080

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/array.js	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

6 years, 5 months ago (2014-06-30 08:39:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22080 (presubmit successful).

Expand Messages | Collapse Messages