Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 353943003: GN: Re-enable platform unit test targets (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
blink-reviews, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

GN: Re-enable platform unit test targets On linux use_webaudio_ffmpeg is true and when it is platform needs to depend on //third_party/ffmpeg. This target is set up in the GN build now (at least for this platform), so it's safe to re-enable. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -67 lines) Patch
M Source/platform/BUILD.gn View 4 chunks +58 lines, -67 lines 0 comments Download
M public/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jamesr
Finally got a chance to look into this - didn't manage to land the ffmpeg ...
6 years, 6 months ago (2014-06-26 05:41:58 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-26 05:46:38 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-26 06:01:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/353943003/1
6 years, 6 months ago (2014-06-26 06:01:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-26 06:45:02 UTC) #5
abarth-chromium
On 2014/06/26 at 05:41:58, jamesr wrote: > Not sure why trybots didn't catch it, guess ...
6 years, 6 months ago (2014-06-26 06:54:06 UTC) #6
jamesr
On 2014/06/26 06:54:06, abarth wrote: > On 2014/06/26 at 05:41:58, jamesr wrote: > > Not ...
6 years, 6 months ago (2014-06-26 06:55:55 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 12:45:59 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 5 months ago (2014-06-27 12:46:00 UTC) #9
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-06-27 21:22:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/353943003/1
6 years, 5 months ago (2014-06-27 21:24:00 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 21:41:27 UTC) #12
Message was sent while issue was closed.
Change committed as 177142

Powered by Google App Engine
This is Rietveld 408576698