Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Side by Side Diff: sdk/lib/_internal/pub/asset/dart/serialize/transformer.dart

Issue 353943002: Throw a more descriptive error if a TransformerGroup has null phases. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library pub.asset.serialize.transformer; 5 library pub.asset.serialize.transformer;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:isolate'; 8 import 'dart:isolate';
9 9
10 import 'package:barback/barback.dart'; 10 import 'package:barback/barback.dart';
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 return { 89 return {
90 'type': type, 90 'type': type,
91 'toString': transformer.toString(), 91 'toString': transformer.toString(),
92 'port': port.sendPort 92 'port': port.sendPort
93 }; 93 };
94 } 94 }
95 95
96 // Converts [group] into a serializable map. 96 // Converts [group] into a serializable map.
97 Map _serializeTransformerGroup(TransformerGroup group) { 97 Map _serializeTransformerGroup(TransformerGroup group) {
98 if (group.phases == null) {
99 throw "TransformerGroup $group phases cannot be null.";
100 }
101
98 return { 102 return {
99 'type': 'TransformerGroup', 103 'type': 'TransformerGroup',
100 'toString': group.toString(), 104 'toString': group.toString(),
101 'phases': group.phases.map((phase) { 105 'phases': group.phases.map((phase) {
102 return phase.map(serializeTransformerLike).toList(); 106 return phase.map(serializeTransformerLike).toList();
103 }).toList() 107 }).toList()
104 }; 108 };
105 } 109 }
106 110
107 /// Converts [transformerLike] into a serializable map. 111 /// Converts [transformerLike] into a serializable map.
108 /// 112 ///
109 /// [transformerLike] can be a [Transformer], an [AggregateTransformer], or a 113 /// [transformerLike] can be a [Transformer], an [AggregateTransformer], or a
110 /// [TransformerGroup]. 114 /// [TransformerGroup].
111 Map serializeTransformerLike(transformerLike) { 115 Map serializeTransformerLike(transformerLike) {
112 if (transformerLike is Transformer) { 116 if (transformerLike is Transformer) {
113 return _serializeTransformer(transformerLike); 117 return _serializeTransformer(transformerLike);
114 } else if (transformerLike is TransformerGroup) { 118 } else if (transformerLike is TransformerGroup) {
115 return _serializeTransformerGroup(transformerLike); 119 return _serializeTransformerGroup(transformerLike);
116 } else { 120 } else {
117 // This has to be last, since "transformerLike is AggregateTransformer" will 121 // This has to be last, since "transformerLike is AggregateTransformer" will
118 // throw on older versions of barback. 122 // throw on older versions of barback.
119 assert(transformerLike is AggregateTransformer); 123 assert(transformerLike is AggregateTransformer);
120 return _serializeAggregateTransformer(transformerLike); 124 return _serializeAggregateTransformer(transformerLike);
121 } 125 }
122 } 126 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698