Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 353823005: Focus disabled optimizations on just BGRAConvolve2D, and only 32-bit. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Focus disabled optimizations on just BGRAConvolve2D, and only 32-bit. Last CL accidentally disabled autovectorization on 64-bit builds too. This fixes that. BUG=skia:2575 Committed: https://skia.googlesource.com/skia/+/2b8a3b8f26658e2933234e97d5d2c0b58935baf4

Patch Set 1 #

Patch Set 2 : skip clang #

Patch Set 3 : fix clang? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M gyp/core.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkConvolver.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 6 months ago (2014-06-25 15:45:50 UTC) #1
mtklein
lgtm
6 years, 6 months ago (2014-06-25 15:47:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/353823005/1
6 years, 6 months ago (2014-06-25 15:48:17 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-25 15:58:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/353823005/40001
6 years, 6 months ago (2014-06-25 15:59:16 UTC) #5
rmistry
LGTM
6 years, 6 months ago (2014-06-25 16:06:45 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 16:14:31 UTC) #7
Message was sent while issue was closed.
Change committed as 2b8a3b8f26658e2933234e97d5d2c0b58935baf4

Powered by Google App Engine
This is Rietveld 408576698