Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: src/debug.cc

Issue 353823004: Remove unused Debug::AfterCompileFlags flags (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.h ('k') | src/liveedit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index cf5cf435d42f1c53b14fe5097dec4f12ac770e10..a6aa0625b0fd879aed8877d1c83006e19e4c0d7e 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -2647,8 +2647,7 @@ void Debug::OnBeforeCompile(Handle<Script> script) {
// Handle debugger actions when a new script is compiled.
-void Debug::OnAfterCompile(Handle<Script> script,
- AfterCompileFlags after_compile_flags) {
+void Debug::OnAfterCompile(Handle<Script> script) {
// Add the newly compiled script to the script cache.
if (script_cache_ != NULL) script_cache_->Add(script);
@@ -2656,9 +2655,6 @@ void Debug::OnAfterCompile(Handle<Script> script,
if (in_debug_scope() || ignore_events()) return;
HandleScope scope(isolate_);
- // Store whether in debugger before entering debugger.
- bool was_in_scope = in_debug_scope();
-
DebugScope debug_scope(this);
if (debug_scope.failed()) return;
@@ -2690,8 +2686,6 @@ void Debug::OnAfterCompile(Handle<Script> script,
argv).is_null()) {
return;
}
- // Bail out based on state or if there is no listener for this event
- if (was_in_scope && (after_compile_flags & SEND_WHEN_DEBUGGING) == 0) return;
// Create the compile state object.
Handle<Object> event_data;
« no previous file with comments | « src/debug.h ('k') | src/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698