Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 353743008: DevTools: Throttle file system refreshes on focus. (Closed)

Created:
6 years, 6 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Throttle file system refreshes on focus. BUG=380860 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177109

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js View 1 chunk +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/FileSystemWorkspaceBinding.js View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/IsolatedFileSystem.js View 3 chunks +9 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Workspace.js View 1 2 chunks +5 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkspaceController.js View 1 2 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vsevik
PTAL
6 years, 6 months ago (2014-06-26 07:55:58 UTC) #1
lushnikov
lgtm https://chromiumcodereview.appspot.com/353743008/diff/1/Source/devtools/front_end/sdk/Workspace.js File Source/devtools/front_end/sdk/Workspace.js (right): https://chromiumcodereview.appspot.com/353743008/diff/1/Source/devtools/front_end/sdk/Workspace.js#newcode446 Source/devtools/front_end/sdk/Workspace.js:446: this._projectDelegate.refresh(path); forgot to pass |callback| in the refresh ...
6 years, 6 months ago (2014-06-26 16:01:25 UTC) #2
vsevik
> https://chromiumcodereview.appspot.com/353743008/diff/1/Source/devtools/front_end/sdk/Workspace.js#newcode446 > Source/devtools/front_end/sdk/Workspace.js:446: > this._projectDelegate.refresh(path); > forgot to pass |callback| in the refresh Done. ...
6 years, 6 months ago (2014-06-26 16:59:24 UTC) #3
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-26 16:59:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/353743008/20001
6 years, 6 months ago (2014-06-26 17:02:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-26 23:04:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 23:05:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/10473) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13006) mac_gpu ...
6 years, 6 months ago (2014-06-26 23:05:35 UTC) #8
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-06-27 12:15:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/353743008/40001
6 years, 5 months ago (2014-06-27 12:16:20 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 15:24:50 UTC) #11
Message was sent while issue was closed.
Change committed as 177109

Powered by Google App Engine
This is Rietveld 408576698