chrome/browser/extensions/api/socket/tls_socket_unittest.cc - Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/tls_socket_unittest.cc

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits from previous patchset. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/socket/tls_socket_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/tls_socket_unittest.cc b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

index 87564e94a2a0c57c82aedd2dbc9f5393a70874de..2558de037f45404dfbe750b5e931b8959694e0b2 100644

--- a/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

+++ b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

@@ -64,6 +64,8 @@ class MockSSLClientSocket : public net::SSLClientSocket {

unsigned char*,

unsigned int));

MOCK_METHOD1(GetTLSUniqueChannelBinding, int(std::string*));

+ MOCK_CONST_METHOD0(InSEssionCache, bool());

wtc 2014/08/04 02:39:47 You have a typo here: InSEssionCache => InSessionC

mshelley 2014/08/04 16:41:59 Done.

+ MOCK_METHOD1(SetHandshakeCompletionCallback, void(const base::Closure&));

MOCK_METHOD1(GetSSLCertRequestInfo, void(net::SSLCertRequestInfo*));

MOCK_METHOD1(GetNextProto,

net::SSLClientSocket::NextProtoStatus(std::string*));

« no previous file with comments | « no previous file | chrome/browser/io_thread.h » ('j') | net/socket/ssl_client_socket_unittest.cc » ('J')